Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 183683017: Use OwnPtrs for heap contains cache and persistent anchor. We were leaking the HeapContainsCache. (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews
Visibility:
Public.

Description

Use OwnPtrs for heap contains cache and persistent anchor. We were leaking the HeapContainsCache. R=haraken@chromium.org, vegorov@chromium.org BUG=348629 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M Source/heap/Handle.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/heap/ThreadState.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/heap/ThreadState.cpp View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-04 07:08:01 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-04 07:09:13 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 07:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/183683017/1
6 years, 9 months ago (2014-03-04 07:35:10 UTC) #4
wibling-chromium
lgtm
6 years, 9 months ago (2014-03-04 08:33:20 UTC) #5
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 9 months ago (2014-03-04 13:52:08 UTC) #6
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-04 13:52:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/183683017/1
6 years, 9 months ago (2014-03-04 13:53:07 UTC) #8
commit-bot: I haz the power
Change committed as 168384
6 years, 9 months ago (2014-03-04 13:53:22 UTC) #9
eae
6 years, 9 months ago (2014-03-06 21:10:24 UTC) #10
Message was sent while issue was closed.
On 2014/03/04 13:53:22, I haz the power (commit-bot) wrote:
> Change committed as 168384

This caused a serious crash on Mac and has been reverted, please see
https://code.google.com/p/chromium/issues/detail?id=349842

Powered by Google App Engine
This is Rietveld 408576698