Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1807163002: Apply -fno-tree-sra and -fno-caller-saves only to Android (Closed)

Created:
4 years, 9 months ago by hashimoto
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, agrieve, Primiano Tucci (use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply -fno-tree-sra and -fno-caller-saves only to Android I don't know why http://crrev.com/293913 has moved these flags outside if(is_android), but the corresponding GYP code (build/config.gypi) is still applying these flags only to Android. BUG=433082 Committed: https://crrev.com/4e700fe2518474e66cf61946ccfe04158e59613c Cr-Commit-Position: refs/heads/master@{#381890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
hashimoto
Please note that I'm just doing this to make GN build as close to GYP ...
4 years, 9 months ago (2016-03-17 10:55:57 UTC) #2
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-18 02:17:08 UTC) #3
Dirk Pranke
+agrieve, primiano, fyi ...
4 years, 9 months ago (2016-03-18 02:17:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807163002/1
4 years, 9 months ago (2016-03-18 04:02:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 04:55:12 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 04:56:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e700fe2518474e66cf61946ccfe04158e59613c
Cr-Commit-Position: refs/heads/master@{#381890}

Powered by Google App Engine
This is Rietveld 408576698