Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1807163002: Apply -fno-tree-sra and -fno-caller-saves only to Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 10
(...skipping 576 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 } else if (is_posix && !is_mac && !is_ios) { 587 } else if (is_posix && !is_mac && !is_ios) {
588 if (current_cpu == "x86") { 588 if (current_cpu == "x86") {
589 if (is_clang) { 589 if (is_clang) {
590 cflags += [ 590 cflags += [
591 # Else building libyuv gives clang's register allocator issues, 591 # Else building libyuv gives clang's register allocator issues,
592 # see llvm.org/PR15798 / crbug.com/233709 592 # see llvm.org/PR15798 / crbug.com/233709
593 "-momit-leaf-frame-pointer", 593 "-momit-leaf-frame-pointer",
594 ] 594 ]
595 } 595 }
596 } else if (current_cpu == "arm") { 596 } else if (current_cpu == "arm") {
597 if (!is_clang) { 597 if (is_android && !is_clang) {
598 # Clang doesn't support these flags. 598 # Clang doesn't support these flags.
599 cflags += [ 599 cflags += [
600 # The tree-sra optimization (scalar replacement for 600 # The tree-sra optimization (scalar replacement for
601 # aggregates enabling subsequent optimizations) leads to 601 # aggregates enabling subsequent optimizations) leads to
602 # invalid code generation when using the Android NDK's 602 # invalid code generation when using the Android NDK's
603 # compiler (r5-r7). This can be verified using 603 # compiler (r5-r7). This can be verified using
604 # webkit_unit_tests' WTF.Checked_int8_t test. 604 # webkit_unit_tests' WTF.Checked_int8_t test.
605 "-fno-tree-sra", 605 "-fno-tree-sra",
606 606
607 # The following option is disabled to improve binary 607 # The following option is disabled to improve binary
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
1338 1338
1339 if (is_ios || is_mac) { 1339 if (is_ios || is_mac) {
1340 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1340 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1341 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1341 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1342 config("enable_arc") { 1342 config("enable_arc") {
1343 common_flags = [ "-fobjc-arc" ] 1343 common_flags = [ "-fobjc-arc" ]
1344 cflags_objc = common_flags 1344 cflags_objc = common_flags
1345 cflags_objcc = common_flags 1345 cflags_objcc = common_flags
1346 } 1346 }
1347 } 1347 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698