Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1807133002: UX updates for IME window. (Closed)

Created:
4 years, 9 months ago by Shu Chen
Modified:
4 years, 9 months ago
Reviewers:
James Su, Azure Wei
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, tfarina, wuyingbing1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UX updates for IME window. 1) The follow cursor window should NOT be auto shown when focusing to an input field. 2) The normal window should NOT show the extension's name on the title bar. BUG=517773 Committed: https://crrev.com/53be152bb6639c0b0da94320af3d2a2d3acb0689 Cr-Commit-Position: refs/heads/master@{#381882}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -43 lines) Patch
M chrome/browser/ui/input_method/input_method_engine.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/input_method/input_method_engine.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/ime/ime_window_frame_view.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/ime/ime_window_frame_view.cc View 1 2 7 chunks +2 lines, -32 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Shu Chen
Azure/James, can you please review this cl? thanks. suzhe@ is for committer approval.
4 years, 9 months ago (2016-03-17 07:48:18 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807133002/1
4 years, 9 months ago (2016-03-17 07:48:37 UTC) #4
Azure Wei
lgtm
4 years, 9 months ago (2016-03-17 07:53:52 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807133002/40001
4 years, 9 months ago (2016-03-18 02:18:52 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/37433) android_chromium_gn_compile_dbg on ...
4 years, 9 months ago (2016-03-18 02:22:21 UTC) #9
James Su
lgtm
4 years, 9 months ago (2016-03-18 03:01:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807133002/40001
4 years, 9 months ago (2016-03-18 03:03:16 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-18 04:49:43 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 04:50:46 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/53be152bb6639c0b0da94320af3d2a2d3acb0689
Cr-Commit-Position: refs/heads/master@{#381882}

Powered by Google App Engine
This is Rietveld 408576698