chrome/browser/ui/input_method/input_method_engine.cc - Issue 1807133002: UX updates for IME window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/input_method/input_method_engine.cc

Issue 1807133002: UX updates for IME window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/input_method/input_method_engine.cc

diff --git a/chrome/browser/ui/input_method/input_method_engine.cc b/chrome/browser/ui/input_method/input_method_engine.cc

index 644ad0a1d95cf3be875c3b1f99a32157992440ef..87f44d8e3b55f46e5e4c53968974af68459c3899 100644

--- a/chrome/browser/ui/input_method/input_method_engine.cc

+++ b/chrome/browser/ui/input_method/input_method_engine.cc

@@ -98,13 +98,6 @@ void InputMethodEngine::CloseImeWindows() {

normal_windows_.clear();

}

-void InputMethodEngine::FocusIn(

- const ui::IMEEngineHandlerInterface::InputContext& input_context) {

- InputMethodEngineBase::FocusIn(input_context);

- if (follow_cursor_window_)

- follow_cursor_window_->Show();

void InputMethodEngine::FocusOut() {

InputMethodEngineBase::FocusOut();

if (follow_cursor_window_)