Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1807093002: DevTools: Resume targets *after* stopping timeline recording. (Closed)

Created:
4 years, 9 months ago by alph
Modified:
4 years, 9 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Resume targets *after* stopping timeline recording. Committed: https://crrev.com/fba25cf5e4aa64d23699698fe640c73db7b8394b Cr-Commit-Position: refs/heads/master@{#381853}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comment. #

Total comments: 2

Patch Set 3 : addressing comment #

Total comments: 2

Patch Set 4 : addressing caseq comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -43 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js View 1 2 7 chunks +30 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
alph
4 years, 9 months ago (2016-03-17 00:30:20 UTC) #2
pfeldman
https://codereview.chromium.org/1807093002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js (right): https://codereview.chromium.org/1807093002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js#newcode102 third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:102: WebInspector.console.log(WebInspector.UIString("A target is disconnected while profiling. Its profile will ...
4 years, 9 months ago (2016-03-17 00:34:31 UTC) #4
alph
https://codereview.chromium.org/1807093002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js (right): https://codereview.chromium.org/1807093002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js#newcode102 third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:102: WebInspector.console.log(WebInspector.UIString("A target is disconnected while profiling. Its profile will ...
4 years, 9 months ago (2016-03-17 01:10:08 UTC) #5
pfeldman
lgtm https://codereview.chromium.org/1807093002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js (right): https://codereview.chromium.org/1807093002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js#newcode142 third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:142: WebInspector.console.log(WebInspector.UIString("CPU profile for a target is not available. ...
4 years, 9 months ago (2016-03-17 19:04:05 UTC) #6
alph
https://codereview.chromium.org/1807093002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js (right): https://codereview.chromium.org/1807093002/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js#newcode142 third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js:142: WebInspector.console.log(WebInspector.UIString("CPU profile for a target is not available. %s", ...
4 years, 9 months ago (2016-03-17 21:12:39 UTC) #7
caseq
lgtm https://codereview.chromium.org/1807093002/diff/60001/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/1807093002/diff/60001/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode612 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:612: _createController: function() let's inline this.
4 years, 9 months ago (2016-03-17 21:28:23 UTC) #9
alph
https://codereview.chromium.org/1807093002/diff/60001/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/1807093002/diff/60001/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode612 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:612: _createController: function() On 2016/03/17 21:28:22, caseq wrote: > let's ...
4 years, 9 months ago (2016-03-17 21:36:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807093002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807093002/80001
4 years, 9 months ago (2016-03-17 21:39:14 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 9 months ago (2016-03-18 00:49:16 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:51:35 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/fba25cf5e4aa64d23699698fe640c73db7b8394b
Cr-Commit-Position: refs/heads/master@{#381853}

Powered by Google App Engine
This is Rietveld 408576698