third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html - Issue 1807093002: DevTools: Resume targets *after* stopping timeline recording.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html

Issue 1807093002: DevTools: Resume targets *after* stopping timeline recording. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing caseq comment. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js ('k') | third_party/WebKit/LayoutTests/inspector/tracing/trace-event-self-time.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html b/third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html

index 212d930d721db49d1f2adca761f9e574eaf4f241..b07a38b98269fc1e41e4a42cba2d10533bd71cad 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/buffer-usage.html

@@ -48,7 +48,7 @@ function test()

__proto__: WebInspector.TimelineLifecycleDelegate

};

- var controller = new WebInspector.TimelineController(new WebInspector.TestTimelineLifecycleDelegate(), InspectorTest.createTracingModel());

+ var controller = new WebInspector.TimelineController(WebInspector.targetManager.mainTarget(), new WebInspector.TestTimelineLifecycleDelegate(), InspectorTest.createTracingModel());

controller.startRecording();

}