Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

Issue 1807033003: Rewrite how RemoteFrameOwners retain life. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.h
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
index 323b420999bb650a25e99176b13de5781f19d435..cba1f0548a39823e4e00175a6d56212260e8b142 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
@@ -5,7 +5,6 @@
#ifndef WebRemoteFrameImpl_h
#define WebRemoteFrameImpl_h
-#include "core/frame/FrameOwner.h"
#include "core/frame/RemoteFrame.h"
#include "public/web/WebRemoteFrame.h"
#include "public/web/WebRemoteFrameClient.h"
@@ -13,9 +12,7 @@
#include "web/WebExport.h"
#include "web/WebFrameImplBase.h"
#include "wtf/Compiler.h"
-#include "wtf/HashMap.h"
#include "wtf/OwnPtr.h"
-#include "wtf/RefCounted.h"
namespace blink {
@@ -45,7 +42,6 @@ public:
bool hasHorizontalScrollbar() const override;
bool hasVerticalScrollbar() const override;
WebView* view() const override;
- void removeChild(WebFrame*) override;
WebDocument document() const override;
WebPerformance performance() const override;
bool dispatchBeforeUnloadEvent() override;
@@ -188,8 +184,6 @@ private:
RefPtrWillBeMember<RemoteFrame> m_frame;
WebRemoteFrameClient* m_client;
- WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner>> m_ownersForChildren;
-
#if ENABLE(OILPAN)
// Oilpan: WebRemoteFrameImpl must remain alive until close() is called.
// Accomplish that by keeping a self-referential Persistent<>. It is

Powered by Google App Engine
This is Rietveld 408576698