Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.h

Issue 1807033003: Rewrite how RemoteFrameOwners retain life. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebRemoteFrameImpl_h 5 #ifndef WebRemoteFrameImpl_h
6 #define WebRemoteFrameImpl_h 6 #define WebRemoteFrameImpl_h
7 7
8 #include "core/frame/FrameOwner.h"
9 #include "core/frame/RemoteFrame.h" 8 #include "core/frame/RemoteFrame.h"
10 #include "public/web/WebRemoteFrame.h" 9 #include "public/web/WebRemoteFrame.h"
11 #include "public/web/WebRemoteFrameClient.h" 10 #include "public/web/WebRemoteFrameClient.h"
12 #include "web/RemoteFrameClientImpl.h" 11 #include "web/RemoteFrameClientImpl.h"
13 #include "web/WebExport.h" 12 #include "web/WebExport.h"
14 #include "web/WebFrameImplBase.h" 13 #include "web/WebFrameImplBase.h"
15 #include "wtf/Compiler.h" 14 #include "wtf/Compiler.h"
16 #include "wtf/HashMap.h"
17 #include "wtf/OwnPtr.h" 15 #include "wtf/OwnPtr.h"
18 #include "wtf/RefCounted.h"
19 16
20 namespace blink { 17 namespace blink {
21 18
22 class FrameHost; 19 class FrameHost;
23 class FrameOwner; 20 class FrameOwner;
24 class RemoteFrame; 21 class RemoteFrame;
25 22
26 class WEB_EXPORT WebRemoteFrameImpl final : public WebFrameImplBase, WTF_NON_EXP ORTED_BASE(public WebRemoteFrame) { 23 class WEB_EXPORT WebRemoteFrameImpl final : public WebFrameImplBase, WTF_NON_EXP ORTED_BASE(public WebRemoteFrame) {
27 public: 24 public:
28 static WebRemoteFrameImpl* create(WebTreeScopeType, WebRemoteFrameClient*, W ebFrame* opener); 25 static WebRemoteFrameImpl* create(WebTreeScopeType, WebRemoteFrameClient*, W ebFrame* opener);
29 ~WebRemoteFrameImpl() override; 26 ~WebRemoteFrameImpl() override;
30 27
31 // WebFrame methods: 28 // WebFrame methods:
32 void close() override; 29 void close() override;
33 WebString uniqueName() const override; 30 WebString uniqueName() const override;
34 WebString assignedName() const override; 31 WebString assignedName() const override;
35 void setName(const WebString&) override; 32 void setName(const WebString&) override;
36 WebVector<WebIconURL> iconURLs(int iconTypesMask) const override; 33 WebVector<WebIconURL> iconURLs(int iconTypesMask) const override;
37 void setRemoteWebLayer(WebLayer*) override; 34 void setRemoteWebLayer(WebLayer*) override;
38 void setSharedWorkerRepositoryClient(WebSharedWorkerRepositoryClient*) overr ide; 35 void setSharedWorkerRepositoryClient(WebSharedWorkerRepositoryClient*) overr ide;
39 void setCanHaveScrollbars(bool) override; 36 void setCanHaveScrollbars(bool) override;
40 WebSize scrollOffset() const override; 37 WebSize scrollOffset() const override;
41 void setScrollOffset(const WebSize&) override; 38 void setScrollOffset(const WebSize&) override;
42 WebSize contentsSize() const override; 39 WebSize contentsSize() const override;
43 bool hasVisibleContent() const override; 40 bool hasVisibleContent() const override;
44 WebRect visibleContentRect() const override; 41 WebRect visibleContentRect() const override;
45 bool hasHorizontalScrollbar() const override; 42 bool hasHorizontalScrollbar() const override;
46 bool hasVerticalScrollbar() const override; 43 bool hasVerticalScrollbar() const override;
47 WebView* view() const override; 44 WebView* view() const override;
48 void removeChild(WebFrame*) override;
49 WebDocument document() const override; 45 WebDocument document() const override;
50 WebPerformance performance() const override; 46 WebPerformance performance() const override;
51 bool dispatchBeforeUnloadEvent() override; 47 bool dispatchBeforeUnloadEvent() override;
52 void dispatchUnloadEvent() override; 48 void dispatchUnloadEvent() override;
53 NPObject* windowObject() const override; 49 NPObject* windowObject() const override;
54 void bindToWindowObject(const WebString& name, NPObject*) override; 50 void bindToWindowObject(const WebString& name, NPObject*) override;
55 void bindToWindowObject(const WebString& name, NPObject*, void*) override; 51 void bindToWindowObject(const WebString& name, NPObject*, void*) override;
56 void executeScript(const WebScriptSource&) override; 52 void executeScript(const WebScriptSource&) override;
57 void executeScriptInIsolatedWorld( 53 void executeScriptInIsolatedWorld(
58 int worldID, const WebScriptSource* sources, unsigned numSources, 54 int worldID, const WebScriptSource* sources, unsigned numSources,
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 // to call these on a WebRemoteFrameImpl. 177 // to call these on a WebRemoteFrameImpl.
182 bool isWebLocalFrame() const override; 178 bool isWebLocalFrame() const override;
183 WebLocalFrame* toWebLocalFrame() override; 179 WebLocalFrame* toWebLocalFrame() override;
184 bool isWebRemoteFrame() const override; 180 bool isWebRemoteFrame() const override;
185 WebRemoteFrame* toWebRemoteFrame() override; 181 WebRemoteFrame* toWebRemoteFrame() override;
186 182
187 OwnPtrWillBeMember<RemoteFrameClientImpl> m_frameClient; 183 OwnPtrWillBeMember<RemoteFrameClientImpl> m_frameClient;
188 RefPtrWillBeMember<RemoteFrame> m_frame; 184 RefPtrWillBeMember<RemoteFrame> m_frame;
189 WebRemoteFrameClient* m_client; 185 WebRemoteFrameClient* m_client;
190 186
191 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner>> m_ownersForChil dren;
192
193 #if ENABLE(OILPAN) 187 #if ENABLE(OILPAN)
194 // Oilpan: WebRemoteFrameImpl must remain alive until close() is called. 188 // Oilpan: WebRemoteFrameImpl must remain alive until close() is called.
195 // Accomplish that by keeping a self-referential Persistent<>. It is 189 // Accomplish that by keeping a self-referential Persistent<>. It is
196 // cleared upon close(). 190 // cleared upon close().
197 SelfKeepAlive<WebRemoteFrameImpl> m_selfKeepAlive; 191 SelfKeepAlive<WebRemoteFrameImpl> m_selfKeepAlive;
198 #endif 192 #endif
199 }; 193 };
200 194
201 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame()); 195 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame());
202 196
203 } // namespace blink 197 } // namespace blink
204 198
205 #endif // WebRemoteFrameImpl_h 199 #endif // WebRemoteFrameImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698