Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 1807033003: Rewrite how RemoteFrameOwners retain life. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index d99fe3b616ee57d65b5b08ecdf285f132ed3fb58..782c0a670ac698cd4c0de89bad20b26cdabc94cb 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -227,7 +227,7 @@
#include "web/MIDIClientProxy.h"
#include "web/NavigatorContentUtilsClientImpl.h"
#include "web/NotificationPermissionClientImpl.h"
-#include "web/RemoteBridgeFrameOwner.h"
+#include "web/RemoteFrameOwner.h"
#include "web/SharedWorkerRepositoryClientImpl.h"
#include "web/SuspendableScriptExecutor.h"
#include "web/TextFinder.h"
@@ -1451,8 +1451,8 @@ WebLocalFrameImpl* WebLocalFrameImpl::createProvisional(WebFrameClient* client,
frame->setOwner(oldFrame->owner());
- if (frame->owner() && !frame->owner()->isLocal()) {
- toRemoteBridgeFrameOwner(frame->owner())->setSandboxFlags(static_cast<SandboxFlags>(flags));
+ if (frame->owner() && frame->owner()->isRemote()) {
+ toRemoteFrameOwner(frame->owner())->setSandboxFlags(static_cast<SandboxFlags>(flags));
// Since a remote frame doesn't get the notifications about frame owner
// property modifications, we need to sync up those properties here.
webFrame->setFrameOwnerProperties(frameOwnerProperties);
@@ -1870,9 +1870,9 @@ void WebLocalFrameImpl::setFrameOwnerProperties(const WebFrameOwnerProperties& f
// for frames with a remote owner.
FrameOwner* owner = frame()->owner();
ASSERT(owner);
- toRemoteBridgeFrameOwner(owner)->setScrollingMode(frameOwnerProperties.scrollingMode);
- toRemoteBridgeFrameOwner(owner)->setMarginWidth(frameOwnerProperties.marginWidth);
- toRemoteBridgeFrameOwner(owner)->setMarginHeight(frameOwnerProperties.marginHeight);
+ toRemoteFrameOwner(owner)->setScrollingMode(frameOwnerProperties.scrollingMode);
+ toRemoteFrameOwner(owner)->setMarginWidth(frameOwnerProperties.marginWidth);
+ toRemoteFrameOwner(owner)->setMarginHeight(frameOwnerProperties.marginHeight);
}
WebLocalFrameImpl* WebLocalFrameImpl::localRoot()

Powered by Google App Engine
This is Rietveld 408576698