[interpreter] Print name together with bytecode handler.

[interpreter] Print name together with bytecode handler.

This prints the mnemonic of the bytecode that a bytecode handler belongs
to, whenever the handler is disassembled (not just during tracing). This
can be helpful when debugging code in GDB or with the snapshot where the
tracing is not available.

R=rmcilroy@chromium.org

Committed: https://crrev.com/ee30626d1a582a51fece28b3de81de1feaf4aa10
Cr-Commit-Position: refs/heads/master@{#34826}

[rmcilroy, 2016-03-16 15:17:32]

lgtm, thanks.

https://codereview.chromium.org/1806883002/diff/1/src/interpreter/interpreter.h
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/1806883002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.h:48: void TraceCodegen(Handle<Code> code);
Could you add a comment above these two functions saying ENABLE_DISASSEMBLER
needs to be defined for them to do anything useful.

[Michael Starzinger, 2016-03-16 15:21:47]

Thanks. Addressed comments. Landing.

https://codereview.chromium.org/1806883002/diff/1/src/interpreter/interpreter.h
File src/interpreter/interpreter.h (right):

https://codereview.chromium.org/1806883002/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.h:48: void TraceCodegen(Handle<Code> code);
On 2016/03/16 15:17:32, rmcilroy wrote:
> Could you add a comment above these two functions saying ENABLE_DISASSEMBLER
> needs to be defined for them to do anything useful.

Done.

[Michael Starzinger, 2016-03-16 16:10:48]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-03-16 16:10:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/1806883002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-03-16 16:10:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806883002/20001

[commit-bot: I haz the power, 2016-03-16 16:22:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 16:22:30]

Description was changed from

==========
[interpreter] Print name together with bytecode handler.

This prints the mnemonic of the bytecode that a bytecode handler belongs
to, whenever the handler is disassembled (not just during tracing). This
can be helpful when debugging code in GDB or with the snapshot where the
tracing is not available.

R=rmcilroy@chromium.org
==========

to

==========
[interpreter] Print name together with bytecode handler.

This prints the mnemonic of the bytecode that a bytecode handler belongs
to, whenever the handler is disassembled (not just during tracing). This
can be helpful when debugging code in GDB or with the snapshot where the
tracing is not available.

R=rmcilroy@chromium.org

Committed: https://crrev.com/ee30626d1a582a51fece28b3de81de1feaf4aa10
Cr-Commit-Position: refs/heads/master@{#34826}
==========

[commit-bot: I haz the power, 2016-03-16 16:22:31]

Patchset 2 (id:??) landed as
https://crrev.com/ee30626d1a582a51fece28b3de81de1feaf4aa10
Cr-Commit-Position: refs/heads/master@{#34826}