Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: src/objects.cc

Issue 1806883002: [interpreter] Print name together with bytecode handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index aa098d6005eadf3fc4ffef7e5c3b5cab93f54fc2..f41407f2864f4ef28206870ffc99c36ae86b827b 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -34,6 +34,7 @@
#include "src/ic/ic.h"
#include "src/identity-map.h"
#include "src/interpreter/bytecode-array-iterator.h"
+#include "src/interpreter/interpreter.h"
#include "src/interpreter/source-position-table.h"
#include "src/isolate-inl.h"
#include "src/keys.h"
@@ -14815,11 +14816,16 @@ void Code::Disassemble(const char* name, std::ostream& os) { // NOLINT
os << "compare_operation = " << Token::Name(stub.op()) << "\n";
}
}
- if ((name != NULL) && (name[0] != '\0')) {
+ if ((name != nullptr) && (name[0] != '\0')) {
os << "name = " << name << "\n";
} else if (kind() == BUILTIN) {
name = GetIsolate()->builtins()->Lookup(instruction_start());
- if (name != NULL) {
+ if (name != nullptr) {
+ os << "name = " << name << "\n";
+ }
+ } else if (kind() == BYTECODE_HANDLER) {
+ name = GetIsolate()->interpreter()->LookupNameOfBytecodeHandler(this);
+ if (name != nullptr) {
os << "name = " << name << "\n";
}
}
« no previous file with comments | « src/interpreter/interpreter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698