Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: components/history_notice_utils.gypi

Issue 1806873002: Add an infrastructure to query history.google.com about other forms of browsing history. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a new component. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history_notice_utils.gypi
diff --git a/components/profile_metrics.gypi b/components/history_notice_utils.gypi
similarity index 54%
copy from components/profile_metrics.gypi
copy to components/history_notice_utils.gypi
index 49e713ada4ce35d0a8f06ae5d98388a7956bf53d..e0c54bb3db67159bf22f86cb649557b87f4cc02e 100644
--- a/components/profile_metrics.gypi
+++ b/components/history_notice_utils.gypi
@@ -1,23 +1,23 @@
-# Copyright 2015 The Chromium Authors. All rights reserved.
sdefresne 2016/03/17 13:11:20 I don't like "history_notice_utils" name. Why not
msramek 2016/03/17 13:58:20 browsing_data_ui SGTM.
+# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
{
'targets': [
{
- # GN version: //components/profile_metrics
sdefresne 2016/03/17 13:11:20 nit: can you have # GN version: //components/hist
- 'target_name': 'profile_metrics',
+ 'target_name': 'history_notice_utils',
'type': 'static_library',
+ 'dependencies': [
+ 'browser_sync_browser',
+ 'history_core_browser',
+ ],
'include_dirs': [
'..',
],
- 'dependencies': [
- '../base/base.gyp:base',
- ],
'sources': [
# Note: sources list duplicated in GN build.
- 'profile_metrics/counts.cc',
- 'profile_metrics/counts.h',
+ 'history_notice_utils/history_notice_utils.cc',
sdefresne 2016/03/17 13:11:20 nit: avoid mixing tab and space (prefer space), an
msramek 2016/03/17 13:58:20 Done. Yeah, this is a copy-paste error. I actually
+ 'history_notice_utils/history_notice_utils.h',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698