Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1806743002: Fix VS 2015 Update 2 specific bug (Closed)

Created:
4 years, 9 months ago by brucedawson
Modified:
4 years, 9 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix VS 2015 Update 2 specific bug When building Chrome with VS 2015 Update 2 RC there is a compiler error: 1> texture_definition.cc 1>base/memory/ref_counted.h(414): error C2027: use of undefined type 'gpu::gles2::GLStreamTextureImage' 1> gpu/command_buffer/service/texture_manager.h(31): note: see declaration of 'gpu::gles2::GLStreamTextureImage' 1> base/memory/ref_counted.h(413): note: while compiling class template member function 'void scoped_refptr<gpu::gles2::GLStreamTextureImage>::AddRef(T *)' This is caused by a compiler bug, together with a type trait used in std::vector: https://twitter.com/StephanTLavavej/status/710191543840219136 A VS bug has been filed at: https://connect.microsoft.com/VisualStudio/feedback/details/2475971 Bug 595189 has a more minimal repro. BUG=440500, 595189 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0 Cr-Commit-Position: refs/heads/master@{#381640}

Patch Set 1 #

Patch Set 2 : More tightly scoped fix. #

Patch Set 3 : Added comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M gpu/command_buffer/service/gl_stream_texture_image.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
brucedawson
This works around an odd compiler bug that a few people are hitting. This would ...
4 years, 9 months ago (2016-03-15 20:33:49 UTC) #3
brucedawson
I've tidied up this fix a bit and I think it's ready to land now. ...
4 years, 9 months ago (2016-03-16 18:31:14 UTC) #8
Zhenyao Mo
On 2016/03/16 18:31:14, brucedawson wrote: > I've tidied up this fix a bit and I ...
4 years, 9 months ago (2016-03-16 19:02:13 UTC) #10
brucedawson
The compile error occurs because the Update 2 version of vector causes the definition of ...
4 years, 9 months ago (2016-03-16 19:23:07 UTC) #11
Zhenyao Mo
On 2016/03/16 19:23:07, brucedawson wrote: > The compile error occurs because the Update 2 version ...
4 years, 9 months ago (2016-03-16 20:17:23 UTC) #12
brucedawson
> But why in texture_definition.cc? I don't see how this file is connected to > ...
4 years, 9 months ago (2016-03-16 20:33:19 UTC) #13
piman
On Wed, Mar 16, 2016 at 1:33 PM, <brucedawson@chromium.org> wrote: > > But why in ...
4 years, 9 months ago (2016-03-16 23:01:39 UTC) #14
brucedawson
> Actually, can't resize() call the copy constructor for > scoped_refptr<GLStreamTextureImage>, which calls AddRef/Release, which ...
4 years, 9 months ago (2016-03-16 23:12:58 UTC) #15
piman
LGTM for this, if you can just add a comment as to why the include ...
4 years, 9 months ago (2016-03-17 00:03:56 UTC) #16
brucedawson
On 2016/03/17 00:03:56, piman wrote: > LGTM for this, if you can just add a ...
4 years, 9 months ago (2016-03-17 00:11:11 UTC) #18
piman
lgtm
4 years, 9 months ago (2016-03-17 00:21:51 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806743002/40001
4 years, 9 months ago (2016-03-17 00:24:50 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 02:04:07 UTC) #23
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4d9ecc15b1ca04d30113408a4d2c428456176ce0 Cr-Commit-Position: refs/heads/master@{#381640}
4 years, 9 months ago (2016-03-17 02:05:24 UTC) #25
brucedawson
3 years, 10 months ago (2017-02-23 22:59:19 UTC) #26
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2710683014/ by brucedawson@chromium.org.

The reason for reverting is: This was a compiler bug workaround and the bug
should have been fixed long ago..

Powered by Google App Engine
This is Rietveld 408576698