Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206
Committed: https://crrev.com/fcd7f803acdaeb2c256347e48ef6eceed72a3507
Cr-Commit-Position: refs/heads/master@{#381648}

[Hadi, 2016-03-16 14:18:29]

Description was changed from

==========
WIP: Remove mojom::EventPtr

BUG=NONE
==========

to

==========
Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206
==========

[Hadi, 2016-03-16 17:37:44]

moshayedi@chromium.org changed reviewers:
+ sky@chromium.org

[Hadi, 2016-03-16 17:37:44]

PTAL.

Planning to remove mojom::EventPtr step by step until we only have it in mojo
interfaces, then switch to native events over ipc.

[Hadi, 2016-03-16 17:39:51]

moshayedi@chromium.org changed reviewers:
+ piman@chromium.org

[Hadi, 2016-03-16 17:39:52]

piman@ can you please review content?

[sky, 2016-03-16 18:12:34]

https://codereview.chromium.org/1806703002/diff/120001/components/mus/public/...
File components/mus/public/cpp/input_event_handler.h (right):

https://codereview.chromium.org/1806703002/diff/120001/components/mus/public/...
components/mus/public/cpp/input_event_handler.h:9: #include "ui/events/event.h"
You should be able to forward declare the event.

https://codereview.chromium.org/1806703002/diff/120001/components/mus/public/...
components/mus/public/cpp/input_event_handler.h:24: ui::Event* event,
const ui::Event&?

https://codereview.chromium.org/1806703002/diff/120001/content/renderer/mus/c...
File content/renderer/mus/compositor_mus_connection.h (right):

https://codereview.chromium.org/1806703002/diff/120001/content/renderer/mus/c...
content/renderer/mus/compositor_mus_connection.h:17: #include
"ui/events/event.h"
Do you really need the include here?

[Hadi, 2016-03-16 18:46:44]

https://codereview.chromium.org/1806703002/diff/120001/components/mus/public/...
File components/mus/public/cpp/input_event_handler.h (right):

https://codereview.chromium.org/1806703002/diff/120001/components/mus/public/...
components/mus/public/cpp/input_event_handler.h:9: #include "ui/events/event.h"
On 2016/03/16 18:12:34, sky wrote:
> You should be able to forward declare the event.

Done.

https://codereview.chromium.org/1806703002/diff/120001/components/mus/public/...
components/mus/public/cpp/input_event_handler.h:24: ui::Event* event,
On 2016/03/16 18:12:34, sky wrote:
> const ui::Event&?

Done. This was infected from PlatformWindowDelegate::DispatchEvent(ui::Event*)
which we call in PlatformWindowMus::OnWindowInputEvent(). I updated
OnWindowInputEvent to accept const ui::Event&. I'll update
PlatformWindowDelegate::DispatchEvent to accept const pointers (or maybe just
const objects) in another CL.

https://codereview.chromium.org/1806703002/diff/120001/content/renderer/mus/c...
File content/renderer/mus/compositor_mus_connection.h (right):

https://codereview.chromium.org/1806703002/diff/120001/content/renderer/mus/c...
content/renderer/mus/compositor_mus_connection.h:17: #include
"ui/events/event.h"
On 2016/03/16 18:12:34, sky wrote:
> Do you really need the include here?

Done.

[sky, 2016-03-16 19:00:52]

LGTM

[piman, 2016-03-17 00:15:51]

lgtm

[Hadi, 2016-03-17 02:41:18]

The CQ bit was checked by moshayedi@chromium.org

[commit-bot: I haz the power, 2016-03-17 02:41:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806703002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806703002/160001

[commit-bot: I haz the power, 2016-03-17 02:46:38]

Description was changed from

==========
Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206
==========

to

==========
Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206
==========

[commit-bot: I haz the power, 2016-03-17 02:46:39]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-17 02:47:39]

Description was changed from

==========
Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206
==========

to

==========
Use ui::Event instead of mojom::EventPtr in mus::InputEventHandler.

We want to get rid of mojom::EventPtr and use ui::Event instead at some point.
This CL removes mojom::EventPtr from one more layer in mus.

BUG=578206

Committed: https://crrev.com/fcd7f803acdaeb2c256347e48ef6eceed72a3507
Cr-Commit-Position: refs/heads/master@{#381648}
==========

[commit-bot: I haz the power, 2016-03-17 02:47:40]

Patchset 9 (id:??) landed as
https://crrev.com/fcd7f803acdaeb2c256347e48ef6eceed72a3507
Cr-Commit-Position: refs/heads/master@{#381648}