Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1814533002: Use ui::Event instead of mojom::EventPtr in mash/wm. (Closed)

Created:
4 years, 9 months ago by Hadi
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, kalyank, sadrul, Mark Dittmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_eventptr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ui::Event instead of mojom::EventPtr in mash/wm. We want to get rid of mojom::EventPtr and use ui::Event instead at some point. This CL removes mojom::EventPtr from one more layer in mus+ash. BUG=578206 Committed: https://crrev.com/d41e5ab53319f2c5d183c2a0912538a0d9fd865e Cr-Commit-Position: refs/heads/master@{#381841}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -75 lines) Patch
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/window_manager_delegate.h View 2 chunks +5 lines, -1 line 0 comments Download
M components/mus/ws/window_manager_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/frame/move_event_handler.cc View 1 2 3 4 5 1 chunk +17 lines, -10 lines 0 comments Download
M mash/wm/frame/move_loop.h View 1 2 3 4 5 4 chunks +8 lines, -4 lines 0 comments Download
M mash/wm/frame/move_loop.cc View 1 2 3 4 5 7 chunks +20 lines, -27 lines 0 comments Download
M mash/wm/frame/move_loop_unittest.cc View 1 2 3 4 5 2 chunks +8 lines, -19 lines 0 comments Download
M mash/wm/root_window_controller.h View 2 chunks +5 lines, -1 line 0 comments Download
M mash/wm/root_window_controller.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mash/wm/window_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/window_manager_application.h View 2 chunks +5 lines, -1 line 0 comments Download
M mash/wm/window_manager_application.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Hadi
PTAL. I'm trying to narrow down the use of mojom::EventPtr only to those places where ...
4 years, 9 months ago (2016-03-17 18:37:53 UTC) #3
Hadi
cc markdittmer@
4 years, 9 months ago (2016-03-17 18:38:44 UTC) #4
sky
LGTM
4 years, 9 months ago (2016-03-17 23:16:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1814533002/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1814533002/90001
4 years, 9 months ago (2016-03-18 00:02:02 UTC) #7
commit-bot: I haz the power
Committed patchset #6 (id:90001)
4 years, 9 months ago (2016-03-18 00:08:27 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:10:46 UTC) #11
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/d41e5ab53319f2c5d183c2a0912538a0d9fd865e
Cr-Commit-Position: refs/heads/master@{#381841}

Powered by Google App Engine
This is Rietveld 408576698