Chromium Code Reviews| Index: build/config/mac/BUILD.gn |
| diff --git a/build/config/mac/BUILD.gn b/build/config/mac/BUILD.gn |
| index af1fbbc092b050f00ac80637df0d2ecc688ebd28..78351b2dcc9cd9feabe1411dbe5b6b2f1a0aa82a 100644 |
| --- a/build/config/mac/BUILD.gn |
| +++ b/build/config/mac/BUILD.gn |
| @@ -86,3 +86,13 @@ config("mac_executable_flags") { |
| # Remove this when targeting >=10.7 since it is the default in that config. |
| ldflags = [ "-Wl,-pie" ] # Position independent. |
| } |
| + |
| +# On Mac, some tools needs to be build with Mac OS X 10.9 or greater SDK. |
| +# Remove this and usage when the default SDK used on OS X is more recent |
| +# than that. |
|
erikchen
2016/03/16 01:59:22
Your comment doesn't match the behavior of your co
|
| +config("macosx_version_min_10_9") { |
| + common_flags = [ "-mmacosx-version-min=10.9" ] |
| + ldflags = common_flags |
| + cflags_objc = common_flags |
| + cflags_objcc = common_flags |
| +} |
|
Dirk Pranke
2016/03/16 01:34:30
Is this actually used in this CL?
This config mak
erikchen
2016/03/16 01:59:22
I assume this gets used in a private, downstream r
Dirk Pranke
2016/03/16 02:25:38
You're asking about the variable that is defined i
sdefresne
2016/03/16 08:40:43
I don't like it either, but it is required to get
|