Chromium Code Reviews

Side by Side Diff: build/config/mac/BUILD.gn

Issue 1806513002: Add config to enable ARC on iOS/OS X to //build/config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iossim
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | ios/third_party/gcdwebserver/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/sysroot.gni") 5 import("//build/config/sysroot.gni")
6 import("//build/config/mac/mac_sdk.gni") 6 import("//build/config/mac/mac_sdk.gni")
7 7
8 # This is included by reference in the //build/config/compiler config that 8 # This is included by reference in the //build/config/compiler config that
9 # is applied to all targets. It is here to separate out the logic. 9 # is applied to all targets. It is here to separate out the logic.
10 # 10 #
(...skipping 68 matching lines...)
79 "-Wl,-rpath,@loader_path/../../..", 79 "-Wl,-rpath,@loader_path/../../..",
80 ] 80 ]
81 } 81 }
82 } 82 }
83 83
84 # On Mac, this is used only for executables. 84 # On Mac, this is used only for executables.
85 config("mac_executable_flags") { 85 config("mac_executable_flags") {
86 # Remove this when targeting >=10.7 since it is the default in that config. 86 # Remove this when targeting >=10.7 since it is the default in that config.
87 ldflags = [ "-Wl,-pie" ] # Position independent. 87 ldflags = [ "-Wl,-pie" ] # Position independent.
88 } 88 }
89
90 # On Mac, some tools needs to be build with Mac OS X 10.9 or greater SDK.
91 # Remove this and usage when the default SDK used on OS X is more recent
92 # than that.
erikchen 2016/03/16 01:59:22 Your comment doesn't match the behavior of your co
93 config("macosx_version_min_10_9") {
94 common_flags = [ "-mmacosx-version-min=10.9" ]
95 ldflags = common_flags
96 cflags_objc = common_flags
97 cflags_objcc = common_flags
98 }
Dirk Pranke 2016/03/16 01:34:30 Is this actually used in this CL? This config mak
erikchen 2016/03/16 01:59:22 I assume this gets used in a private, downstream r
Dirk Pranke 2016/03/16 02:25:38 You're asking about the variable that is defined i
sdefresne 2016/03/16 08:40:43 I don't like it either, but it is required to get
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | ios/third_party/gcdwebserver/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine