third_party/WebKit/LayoutTests/editing/selection/end-of-document.html - Issue 1806423003: Convert editing/selection layout tests to use w3c test harness, volume 6

Unified Diff: third_party/WebKit/LayoutTests/editing/selection/end-of-document.html

Issue 1806423003: Convert editing/selection layout tests to use w3c test harness, volume 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/editable-html-element.html ('k') | third_party/WebKit/LayoutTests/editing/selection/focus_editable_html.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/editing/selection/end-of-document.html

diff --git a/third_party/WebKit/LayoutTests/editing/selection/end-of-document.html b/third_party/WebKit/LayoutTests/editing/selection/end-of-document.html

deleted file mode 100644

index 4346b455b6ebebeed13b9b7db0f579f309996309..0000000000000000000000000000000000000000

--- a/third_party/WebKit/LayoutTests/editing/selection/end-of-document.html

+++ /dev/null

@@ -1,49 +0,0 @@

-<html>

-<style>

-blockquote {

- color: blue;

-</style>

-<script src=../editing.js language="JavaScript" type="text/JavaScript"></script>

-<script>

-function editingTest() {

- selectAllCommand();

- moveSelectionForwardByCharacterCommand();

- moveSelectionBackwardByLineCommand();

-</script>

-<body onload="runEditingTest();">

-<div id="test" contentEditable style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space;">

-<DIV class=3D"AppleOriginalContents"><DIV>On Feb 1, 2006, at 7:37 PM, David Hyatt wrote:</DIV><BR class=3D"Apple-interchange-newline"><BLOCKQUOTE type=3D"cite"><DIV

-style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px;

-margin-left: 0px; ">While reworking images I ran into something that

-really concerns me.<SPAN class=3D"Apple-converted-space">

-</SPAN>WebElementImageKey is a key added to the elementAtPoint

-dictionary and the key's value is an NSImage.<SPAN

-class=3D"Apple-converted-space"> </SPAN>Unfortunately we use

-CGImageRef now.<SPAN class=3D"Apple-converted-space"> </SPAN>What

-this means is that as you move the mouse around a web page we are

-aggressively mallocing NSImages that then move into our image cache and

-stay around until the CGImageRef goes away (which could be a long

-time).</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px;

-margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV

-style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px;

-margin-left: 0px; ">I think this is terrible but am not sure how to fix

-it.<SPAN class=3D"Apple-converted-space"> </SPAN>I assume this key is

-public API.<SPAN class=3D"Apple-converted-space"> </SPAN>Could we

-change the key's value to be a CGImageRef instead?<SPAN

-class=3D"Apple-converted-space"> </SPAN>Could we just eliminate the

-key in favor of a DOM extension method for accessing an

-NSImage?</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px;

-margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV

-style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px;

-margin-left: 0px; ">dave</DIV><DIV style=3D"margin-top: 0px;

-margin-right: 0px; margin-bottom: 0px; margin-left: 0px;

-">(hyatt@apple.com)</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px;"><BR></DIV> </BLOCKQUOTE></DIV><BR>

-</div>

-</body>

-</html>