third_party/WebKit/LayoutTests/editing/selection/end-of-document.html - Issue 1806423003: Convert editing/selection layout tests to use w3c test harness, volume 6

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/selection/end-of-document.html

Issue 1806423003: Convert editing/selection layout tests to use w3c test harness, volume 6 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/editing/selection/editable-html-element.html ('k') | third_party/WebKit/LayoutTests/editing/selection/focus_editable_html.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <html>

2 <style>

3 blockquote {

4 color: blue;

5 }

6 </style>

7 <script src=../editing.js language="JavaScript" type="text/JavaScript"></script>

8 <script>

9 function editingTest() {

10 selectAllCommand();

11 moveSelectionForwardByCharacterCommand();

12 moveSelectionBackwardByLineCommand();

13 }

14 </script>

15

16 <body onload="runEditingTest();">

17

18 <div id="test" contentEditable style="word-wrap: break-word; -khtml-nbsp-mode: s pace; -khtml-line-break: after-white-space;">

19

20 <DIV class=3D"AppleOriginalContents"><DIV>On Feb 1, 2006, at 7:37 PM, David Hyat t wrote:</DIV><BR class=3D"Apple-interchange-newline"><BLOCKQUOTE type=3D"cite"> <DIV

21 style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px;

22 margin-left: 0px; ">While reworking images I ran into something that

23 really concerns me.<SPAN class=3D"Apple-converted-space">

24 </SPAN>WebElementImageKey is a key added to the elementAtPoint

25 dictionary and the key's value is an NSImage.<SPAN

26 class=3D"Apple-converted-space"> </SPAN>Unfortunately we use

27 CGImageRef now.<SPAN class=3D"Apple-converted-space"> </SPAN>What

28 this means is that as you move the mouse around a web page we are

29 aggressively mallocing NSImages that then move into our image cache and

30 stay around until the CGImageRef goes away (which could be a long

31 time).</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px;

32 margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV

33 style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px;

34 margin-left: 0px; ">I think this is terrible but am not sure how to fix

35 it.<SPAN class=3D"Apple-converted-space"> </SPAN>I assume this key is

36 public API.<SPAN class=3D"Apple-converted-space"> </SPAN>Could we

37 change the key's value to be a CGImageRef instead?<SPAN

38 class=3D"Apple-converted-space"> </SPAN>Could we just eliminate the

39 key in favor of a DOM extension method for accessing an

40 NSImage?</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px;

41 margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><BR></DIV><DIV

42 style=3D"margin-top: 0px; margin-right: 0px; margin-bottom: 0px;

43 margin-left: 0px; ">dave</DIV><DIV style=3D"margin-top: 0px;

44 margin-right: 0px; margin-bottom: 0px; margin-left: 0px;

45 ">(hyatt@apple.com)</DIV><DIV style=3D"margin-top: 0px; margin-right: 0px; margi n-bottom: 0px; margin-left: 0px; min-height: 14px;"><BR></DIV> </BLOCKQUOTE></DI V><BR>

46 </div>

47

48 </body>

49 </html>

OLD	NEW