Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1806423003: Convert editing/selection layout tests to use w3c test harness, volume 6 (Closed)

Created:
4 years, 9 months ago by yosin_UTC9
Modified:
4 years, 9 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/selection layout tests to use w3c test harness, volume 6 This patch converts following layout tests in editing/selection to use w3c test harness and rename file to describe what these test do for ease of maintenance. * caret-before-select.html => collapse/collapse_before_select.html * editable-html-element.html => focus_editable_html_element.html * end-of-document.html => modify_move/move_backward_line_end_of_document.html * focus_editable_html.html => focus_editable_html_element_scroll.html * mixed-editability-3.html => modify_move/move_forward_line_mixed_editability.html BUG=n/a TEST=n/a; no behavior changes Committed: https://crrev.com/48d23a65713682cf291ab66146d4de36527c6365 Cr-Commit-Position: refs/heads/master@{#381925}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -420 lines) Patch
D third_party/WebKit/LayoutTests/editing/selection/caret-before-select.html View 1 chunk +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/collapse/collapse_before_select.html View 1 chunk +18 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/editable-html-element.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/end-of-document.html View 1 chunk +0 lines, -49 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/focus_editable_html.html View 1 chunk +0 lines, -14 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/focus_editable_html_element.html View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/focus_editable_html_element_scroll.html View 1 chunk +24 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/selection/mixed-editability-3.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/modify_move/move_backward_line_end_of_document.html View 2 chunks +19 lines, -17 lines 0 comments Download
A third_party/WebKit/LayoutTests/editing/selection/modify_move/move_forward_line_mixed_editability.html View 1 chunk +27 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/editing/selection/caret-before-select-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/android/editing/selection/caret-before-select-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/caret-before-select-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/caret-before-select-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/editable-html-element-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/editable-html-element-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/focus_editable_html-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/focus_editable_html-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/linux/editing/selection/mixed-editability-3-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/selection/caret-before-select-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/selection/caret-before-select-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/editing/selection/caret-before-select-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac-mac10.9/editing/selection/caret-before-select-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/caret-before-select-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/caret-before-select-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/editable-html-element-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/editable-html-element-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/focus_editable_html-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/focus_editable_html-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/mac/editing/selection/mixed-editability-3-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/caret-before-select-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/caret-before-select-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/editable-html-element-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/editable-html-element-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/focus_editable_html-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/focus_editable_html-expected.txt View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/mixed-editability-3-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/editing/selection/mixed-editability-3-expected.txt View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
yosin_UTC9
PTAL
4 years, 9 months ago (2016-03-18 07:55:42 UTC) #3
yoichio
lgtm
4 years, 9 months ago (2016-03-18 08:36:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806423003/1
4 years, 9 months ago (2016-03-18 09:22:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 10:18:54 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 10:20:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48d23a65713682cf291ab66146d4de36527c6365
Cr-Commit-Position: refs/heads/master@{#381925}

Powered by Google App Engine
This is Rietveld 408576698