DescriptionRevert of Shape unicode-range: font faces in only one iteration (patchset #7 id:180001 of https://codereview.chromium.org/1806653002/ )
Reason for revert:
Reverting on a suspicion that this is a root cause to the failures of webkit_unit_tests on Webkit Android (Nexus4) bots, e.g.
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/44725
Original issue's description:
> Shape unicode-range: font faces in only one iteration
>
> Previously, we incorrectly split CSS composite faces into multiple faces
> for shaping, one for each comma-separated entry of unicode-range:. This
> breaks shaping of ligatures and other features when the characters that
> ought to be shaped combined were in different unicode-range entries. It
> is also inefficient for subsetted web fonts that use unicode-range:
> extensively, for example Google Fonts and Adobe TypeKit.
>
> The fix is to transfer the UnicodeRangeSet information from CSSFontFace
> to HarfBuzzFace and only restrict the glyph lookup function to the whole
> unicode-range information, instead of restricting it to a single entry
> and shaping multiple times with the same face. This should have a slight
> performance benefit as well.
>
> BUG=583450
> TEST=fast/css/font-face-unicode-range-ligatures.html
> R=eae, behdad
>
> Committed: https://crrev.com/9694005f93116f9c9cc73fa99132fa4475a0cdab
> Cr-Commit-Position: refs/heads/master@{#381683}
TBR=behdad@chromium.org,eae@chromium.org,drott@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=583450
Committed: https://crrev.com/60adcbb3ec944fa45c3b7cd0c45b38b1120e7b08
Cr-Commit-Position: refs/heads/master@{#381736}
Patch Set 1 #Messages
Total messages: 6 (2 generated)
|