Chromium Code Reviews| Index: media/audio/linux/audio_manager_linux.cc |
| diff --git a/media/audio/linux/audio_manager_linux.cc b/media/audio/linux/audio_manager_linux.cc |
| index 0e7c9810a5c29e3b9a4e6e9c60e89163e60f850a..6d91b386048ff7a788fb1ef5c887ee93142ad544 100644 |
| --- a/media/audio/linux/audio_manager_linux.cc |
| +++ b/media/audio/linux/audio_manager_linux.cc |
| @@ -4,6 +4,8 @@ |
| #include "base/command_line.h" |
| #include "base/metrics/histogram.h" |
| +#include "media/base/media_switches.h" |
| + |
| #if defined(USE_ALSA) |
| #include "media/audio/alsa/audio_manager_alsa.h" |
| #else |
| @@ -15,7 +17,6 @@ |
| #if defined(USE_PULSEAUDIO) |
| #include "media/audio/pulse/audio_manager_pulse.h" |
| #endif |
| -#include "media/base/media_switches.h" |
| namespace media { |
| @@ -26,27 +27,38 @@ enum LinuxAudioIO { |
| kAudioIOMax = kCras // Must always be equal to largest logged entry. |
| }; |
| -AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) { |
| +ScopedAudioManagerPtr CreateAudioManager( |
| + scoped_refptr<base::SingleThreadTaskRunner> task_runner, |
| + scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner, |
| + AudioLogFactory* audio_log_factory) { |
| #if defined(USE_CRAS) |
| if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) { |
| UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1); |
| - return new AudioManagerCras(audio_log_factory); |
| + return ScopedAudioManagerPtr(new AudioManagerCras( |
| + task_runner, worker_task_runner, audio_log_factory)); |
| } |
| #endif |
| #if defined(USE_PULSEAUDIO) |
| - AudioManager* manager = AudioManagerPulse::Create(audio_log_factory); |
| - if (manager) { |
| + scoped_ptr<AudioManagerPulse, AudioManagerDeleter> manager( |
|
DaleCurtis
2016/03/22 21:58:27
ScopedPtrAudioManager?
alokp
2016/03/22 22:23:39
I need a pointer for AudioManagerPulse to be able
|
| + new AudioManagerPulse(task_runner, worker_task_runner, |
| + audio_log_factory)); |
| + if (manager->Init()) { |
| UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1); |
| - return manager; |
| + return std::move(manager); |
| + } else { |
| + DVLOG(1) << "PulseAudio is not available on the OS"; |
| + manager.reset(); |
| } |
| #endif |
| #if defined(USE_ALSA) |
| UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1); |
| - return new AudioManagerAlsa(audio_log_factory); |
| + return ScopedAudioManagerPtr( |
| + new AudioManagerAlsa(task_runner, worker_task_runner, audio_log_factory)); |
| #else |
| - return new FakeAudioManager(audio_log_factory); |
| + return ScopedAudioManagerPtr( |
| + new FakeAudioManager(task_runner, worker_task_runner, audio_log_factory)); |
| #endif |
| } |