Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: media/audio/linux/audio_manager_linux.cc

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/metrics/histogram.h" 6 #include "base/metrics/histogram.h"
7 #include "media/base/media_switches.h"
8
7 #if defined(USE_ALSA) 9 #if defined(USE_ALSA)
8 #include "media/audio/alsa/audio_manager_alsa.h" 10 #include "media/audio/alsa/audio_manager_alsa.h"
9 #else 11 #else
10 #include "media/audio/fake_audio_manager.h" 12 #include "media/audio/fake_audio_manager.h"
11 #endif 13 #endif
12 #if defined(USE_CRAS) 14 #if defined(USE_CRAS)
13 #include "media/audio/cras/audio_manager_cras.h" 15 #include "media/audio/cras/audio_manager_cras.h"
14 #endif 16 #endif
15 #if defined(USE_PULSEAUDIO) 17 #if defined(USE_PULSEAUDIO)
16 #include "media/audio/pulse/audio_manager_pulse.h" 18 #include "media/audio/pulse/audio_manager_pulse.h"
17 #endif 19 #endif
18 #include "media/base/media_switches.h"
19 20
20 namespace media { 21 namespace media {
21 22
22 enum LinuxAudioIO { 23 enum LinuxAudioIO {
23 kPulse, 24 kPulse,
24 kAlsa, 25 kAlsa,
25 kCras, 26 kCras,
26 kAudioIOMax = kCras // Must always be equal to largest logged entry. 27 kAudioIOMax = kCras // Must always be equal to largest logged entry.
27 }; 28 };
28 29
29 AudioManager* CreateAudioManager(AudioLogFactory* audio_log_factory) { 30 ScopedAudioManagerPtr CreateAudioManager(
31 scoped_refptr<base::SingleThreadTaskRunner> task_runner,
32 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
33 AudioLogFactory* audio_log_factory) {
30 #if defined(USE_CRAS) 34 #if defined(USE_CRAS)
31 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) { 35 if (base::CommandLine::ForCurrentProcess()->HasSwitch(switches::kUseCras)) {
32 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1); 36 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kCras, kAudioIOMax + 1);
33 return new AudioManagerCras(audio_log_factory); 37 return ScopedAudioManagerPtr(new AudioManagerCras(
38 task_runner, worker_task_runner, audio_log_factory));
34 } 39 }
35 #endif 40 #endif
36 41
37 #if defined(USE_PULSEAUDIO) 42 #if defined(USE_PULSEAUDIO)
38 AudioManager* manager = AudioManagerPulse::Create(audio_log_factory); 43 scoped_ptr<AudioManagerPulse, AudioManagerDeleter> manager(
DaleCurtis 2016/03/22 21:58:27 ScopedPtrAudioManager?
alokp 2016/03/22 22:23:39 I need a pointer for AudioManagerPulse to be able
39 if (manager) { 44 new AudioManagerPulse(task_runner, worker_task_runner,
45 audio_log_factory));
46 if (manager->Init()) {
40 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1); 47 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kPulse, kAudioIOMax + 1);
41 return manager; 48 return std::move(manager);
49 } else {
50 DVLOG(1) << "PulseAudio is not available on the OS";
51 manager.reset();
42 } 52 }
43 #endif 53 #endif
44 54
45 #if defined(USE_ALSA) 55 #if defined(USE_ALSA)
46 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1); 56 UMA_HISTOGRAM_ENUMERATION("Media.LinuxAudioIO", kAlsa, kAudioIOMax + 1);
47 return new AudioManagerAlsa(audio_log_factory); 57 return ScopedAudioManagerPtr(
58 new AudioManagerAlsa(task_runner, worker_task_runner, audio_log_factory));
48 #else 59 #else
49 return new FakeAudioManager(audio_log_factory); 60 return ScopedAudioManagerPtr(
61 new FakeAudioManager(task_runner, worker_task_runner, audio_log_factory));
50 #endif 62 #endif
51 } 63 }
52 64
53 } // namespace media 65 } // namespace media
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698