Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: media/audio/audio_manager_factory.h

Issue 1806313003: Pass task runners to AudioManager constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/audio/audio_manager_factory.h
diff --git a/media/audio/audio_manager_factory.h b/media/audio/audio_manager_factory.h
index 11f1338d0ba596d9af6817ed1b1f2e8bbc955929..09d209d971b55ab1e5a856f2f945b56c08e88b31 100644
--- a/media/audio/audio_manager_factory.h
+++ b/media/audio/audio_manager_factory.h
@@ -10,6 +10,7 @@
namespace media {
class AudioManager;
+class AudioManagerDeleter;
class AudioLogFactory;
// Allows a platform-specific implementation of AudioManager to be provided in
@@ -20,7 +21,10 @@ class MEDIA_EXPORT AudioManagerFactory {
// Creates an instance of AudioManager implementation. Caller owns the
// returned instance. |audio_log_factory| must outlive the returned instance.
- virtual AudioManager* CreateInstance(AudioLogFactory* audio_log_factory) = 0;
+ virtual scoped_ptr<AudioManager, AudioManagerDeleter> CreateInstance(
DaleCurtis 2016/03/22 21:58:27 ScopedPtrAudioManager?
alokp 2016/03/22 22:23:39 I would then need to include audio_manager.h here.
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner,
+ scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner,
+ AudioLogFactory* audio_log_factory) = 0;
};
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698