Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1806273002: Fix gyp build. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix gyp build. NOTRY=true NOTREECHECKS=true TBR=machenbach@chromium.org Committed: https://crrev.com/974186e3386728af27d9b01ccd02788032c63fe9 Cr-Commit-Position: refs/heads/master@{#34850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/snapshot/mksnapshot.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Yang
4 years, 9 months ago (2016-03-17 10:40:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806273002/1
4 years, 9 months ago (2016-03-17 10:41:09 UTC) #5
Michael Achenbach
lgtm
4 years, 9 months ago (2016-03-17 10:45:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806273002/1
4 years, 9 months ago (2016-03-17 10:46:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 10:47:43 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 10:49:18 UTC) #15
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/974186e3386728af27d9b01ccd02788032c63fe9
Cr-Commit-Position: refs/heads/master@{#34850}

Powered by Google App Engine
This is Rietveld 408576698