src/snapshot/mksnapshot.cc - Issue 1806273002: Fix gyp build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/snapshot/mksnapshot.cc

Issue 1806273002: Fix gyp build. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/snapshot/mksnapshot.cc

diff --git a/src/snapshot/mksnapshot.cc b/src/snapshot/mksnapshot.cc

index 9d7b9e4dd62ebf02c9b0d78c6db0f09d1b8c5947..c5a3509186ececcf63865ecd6d983b42b9207824 100644

--- a/src/snapshot/mksnapshot.cc

+++ b/src/snapshot/mksnapshot.cc

@@ -111,7 +111,6 @@ class SnapshotWriter {

char* GetExtraCode(char* filename, const char* description) {

if (filename == NULL || strlen(filename) == 0) return NULL;

- if (strcmp(filename, "-") == 0) return NULL;

::printf("Loading script for %s: %s\n", description, filename);

FILE* file = base::OS::FOpen(filename, "rb");

if (file == NULL) {

« no previous file with comments | « no previous file | tools/gyp/v8.gyp » ('j') | no next file with comments »