Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Issue 1806163002: Track USB alternate interface state in Blink. (Closed)

Created:
4 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 9 months ago
Reviewers:
juncai
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@blink_interface_state
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track USB alternate interface state in Blink. This patch adds logic to track which alternate interface has been selected. This isn't too interesting by itself but is a step towards knowing which endpoints are available. BUG=593164 Committed: https://crrev.com/92c1f849580dea46a5ddc1a3762a86ea5a9b7cf4 Cr-Commit-Position: refs/heads/master@{#382486}

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 1

Patch Set 3 : Fixed typo and rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/usb/usbDevice.html View 1 2 8 chunks +25 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.h View 1 4 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.cpp View 1 5 chunks +71 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBDevice.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBInterface.idl View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 9 months ago (2016-03-21 20:52:38 UTC) #2
juncai
LGTM with nits. https://codereview.chromium.org/1806163002/diff/20001/third_party/WebKit/LayoutTests/usb/usbDevice.html File third_party/WebKit/LayoutTests/usb/usbDevice.html (right): https://codereview.chromium.org/1806163002/diff/20001/third_party/WebKit/LayoutTests/usb/usbDevice.html#newcode314 third_party/WebKit/LayoutTests/usb/usbDevice.html:314: }, 'cannot select a non-existant alternate ...
4 years, 9 months ago (2016-03-22 01:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806163002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806163002/40001
4 years, 9 months ago (2016-03-22 01:40:17 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-22 02:59:17 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 03:00:31 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/92c1f849580dea46a5ddc1a3762a86ea5a9b7cf4
Cr-Commit-Position: refs/heads/master@{#382486}

Powered by Google App Engine
This is Rietveld 408576698