Close USB device connections when the page is hidden.

Close USB device connections when the page is hidden.

This is a temporary measure to make up for the lack of a visible
indication that a page has an open connection to a USB device. If the
page becomes hidden then all open device connections are closed and
cannot be reopened until it is visible again.

BUG=595375
Committed: https://crrev.com/d83aa53f1beb27037f5f77fc06d5b6b0c2e05642
Cr-Commit-Position: refs/heads/master@{#382654}

[Reilly Grant (use Gerrit), 2016-03-22 01:46:36]

Patchset #2 (id:20001) has been deleted

[Reilly Grant (use Gerrit), 2016-03-22 01:57:20]

reillyg@chromium.org changed reviewers:
+ ortuno@chromium.org

[Reilly Grant (use Gerrit), 2016-03-22 01:57:20]

Please take a look.

[ortuno, 2016-03-22 02:09:08]

lgtm

https://codereview.chromium.org/1820173002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1820173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:682: if
(ensurePageVisible(resolver)) {
nit: if you want to save a level of indentation:
if (!ensurePageVisible(resolver))
  return false;
...

https://codereview.chromium.org/1820173002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webusb/USBDevice.cpp:695: if
(ensurePageVisible(resolver)) {
nit: same here

[Reilly Grant (use Gerrit), 2016-03-22 18:16:18]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-03-22 18:16:18]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org
Link to the patchset: https://codereview.chromium.org/1820173002/#ps60001
(title: "Rebased and fixed nit.")

[commit-bot: I haz the power, 2016-03-22 18:16:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1820173002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1820173002/60001

[commit-bot: I haz the power, 2016-03-22 19:54:14]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-22 19:55:38]

Description was changed from

==========
Close USB device connections when the page is hidden.

This is a temporary measure to make up for the lack of a visible
indication that a page has an open connection to a USB device. If the
page becomes hidden then all open device connections are closed and
cannot be reopened until it is visible again.

BUG=595375
==========

to

==========
Close USB device connections when the page is hidden.

This is a temporary measure to make up for the lack of a visible
indication that a page has an open connection to a USB device. If the
page becomes hidden then all open device connections are closed and
cannot be reopened until it is visible again.

BUG=595375

Committed: https://crrev.com/d83aa53f1beb27037f5f77fc06d5b6b0c2e05642
Cr-Commit-Position: refs/heads/master@{#382654}
==========

[commit-bot: I haz the power, 2016-03-22 19:55:38]

Patchset 3 (id:??) landed as
https://crrev.com/d83aa53f1beb27037f5f77fc06d5b6b0c2e05642
Cr-Commit-Position: refs/heads/master@{#382654}