Let SVGElement handle SVGLangSpace attributes parsing

Let SVGElement handle SVGLangSpace attributes parsing

Now that SVGLangSpace attributes were merged into SVGElement and that
SVGElement takes care of parsing them, we can stop doing it in some
of the subclasses.

Some subclasses still handle SVGLangSpace attributes on their own because
they require special handling (e.g. layout invalidation if the attribute
changes).

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153516

[Stephen Chennney, 2013-07-03 14:22:15]

Which classes still need their own parsing? Do they inherit from SVGElement and
hence end up parsing twice? Could you explain the situation with an example.

[do-not-use, 2013-07-03 14:28:43]

On 2013/07/03 14:22:15, Stephen Chenney wrote:
> Which classes still need their own parsing? Do they inherit from SVGElement
and
> hence end up parsing twice? Could you explain the situation with an example.

All the shapes for example (e.g. SVGCircleElement). Yes, they inherit from
SVGElement. But no, we don't parse twice because we ask the parent to parse an
attribute only if it is not supported (and SVGLangSpace attributes are marked as
supported for these classes).

E.g.

bool SVGCircleElement::isSupportedAttribute(const QualifiedName& attrName)
{
    DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
    if (supportedAttributes.isEmpty()) {
        SVGLangSpace::addSupportedAttributes(supportedAttributes);
        // ...
        supportedAttributes.add(SVGNames::rAttr);
    }
    return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
}

void SVGCircleElement::parseAttribute(const QualifiedName& name, const
AtomicString& value)
{
    SVGParsingError parseError = NoError;

    if (!isSupportedAttribute(name))
        SVGGraphicsElement::parseAttribute(name, value);
    else if (name == SVGNames::cxAttr)
        setCxBaseValue(SVGLength::construct(LengthModeWidth, value,
parseError));
// ...

[Stephen Chennney, 2013-07-03 15:39:07]

Thanks. That helps.

LGTM

[commit-bot: I haz the power, 2013-07-03 15:39:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18060005/1

[commit-bot: I haz the power, 2013-07-03 17:13:03]

Change committed as 153516