Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Side by Side Diff: Source/core/svg/SVGSymbolElement.cpp

Issue 18060005: Let SVGElement handle SVGLangSpace attributes parsing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGStyleElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 51
52 PassRefPtr<SVGSymbolElement> SVGSymbolElement::create(const QualifiedName& tagNa me, Document* document) 52 PassRefPtr<SVGSymbolElement> SVGSymbolElement::create(const QualifiedName& tagNa me, Document* document)
53 { 53 {
54 return adoptRef(new SVGSymbolElement(tagName, document)); 54 return adoptRef(new SVGSymbolElement(tagName, document));
55 } 55 }
56 56
57 bool SVGSymbolElement::isSupportedAttribute(const QualifiedName& attrName) 57 bool SVGSymbolElement::isSupportedAttribute(const QualifiedName& attrName)
58 { 58 {
59 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ()); 59 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
60 if (supportedAttributes.isEmpty()) { 60 if (supportedAttributes.isEmpty()) {
61 SVGLangSpace::addSupportedAttributes(supportedAttributes);
62 SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes ); 61 SVGExternalResourcesRequired::addSupportedAttributes(supportedAttributes );
63 SVGFitToViewBox::addSupportedAttributes(supportedAttributes); 62 SVGFitToViewBox::addSupportedAttributes(supportedAttributes);
64 } 63 }
65 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName); 64 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
66 } 65 }
67 66
68 void SVGSymbolElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value) 67 void SVGSymbolElement::parseAttribute(const QualifiedName& name, const AtomicStr ing& value)
69 { 68 {
70 if (!isSupportedAttribute(name)) { 69 if (!isSupportedAttribute(name)) {
71 SVGStyledElement::parseAttribute(name, value); 70 SVGStyledElement::parseAttribute(name, value);
72 return; 71 return;
73 } 72 }
74 73
75 if (SVGLangSpace::parseAttribute(name, value))
76 return;
77 if (SVGExternalResourcesRequired::parseAttribute(name, value)) 74 if (SVGExternalResourcesRequired::parseAttribute(name, value))
78 return; 75 return;
79 if (SVGFitToViewBox::parseAttribute(this, name, value)) 76 if (SVGFitToViewBox::parseAttribute(this, name, value))
80 return; 77 return;
81 78
82 ASSERT_NOT_REACHED(); 79 ASSERT_NOT_REACHED();
83 } 80 }
84 81
85 void SVGSymbolElement::svgAttributeChanged(const QualifiedName& attrName) 82 void SVGSymbolElement::svgAttributeChanged(const QualifiedName& attrName)
86 { 83 {
(...skipping 13 matching lines...) Expand all
100 { 97 {
101 return hasAttribute(SVGNames::viewBoxAttr); 98 return hasAttribute(SVGNames::viewBoxAttr);
102 } 99 }
103 100
104 RenderObject* SVGSymbolElement::createRenderer(RenderStyle*) 101 RenderObject* SVGSymbolElement::createRenderer(RenderStyle*)
105 { 102 {
106 return new (document()->renderArena()) RenderSVGHiddenContainer(this); 103 return new (document()->renderArena()) RenderSVGHiddenContainer(this);
107 } 104 }
108 105
109 } 106 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGStyleElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698