src/utils/SkDashPath.cpp - Issue 1805963002: allow one zero length dash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkDashPath.cpp

Issue 1805963002: allow one zero length dash (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: allow one zero length dash Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkDashPath.cpp

diff --git a/src/utils/SkDashPath.cpp b/src/utils/SkDashPath.cpp

index cd01a9972b94695e1a4b27e1e819bb675fcb56e0..2efe1f4957379bbf50f020a1558c98b758f7030d 100644

--- a/src/utils/SkDashPath.cpp

+++ b/src/utils/SkDashPath.cpp

@@ -305,7 +305,7 @@ bool SkDashPath::FilterDashPath(SkPath* dst, const SkPath& src, SkStrokeRec* rec

// extend if we ended on a segment and we need to join up with the (skipped) initial segment

if (meas.isClosed() && is_even(initialDashIndex) &&

- initialDashLength > 0) {

+ initialDashLength >= 0) {

meas.getSegment(0, initialDashLength, dst, !addedSegment);

++segCount;

}