src/effects/SkDashPathEffect.cpp - Issue 1805963002: allow one zero length dash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkDashPathEffect.cpp

Issue 1805963002: allow one zero length dash (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: allow one zero length dash Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkDashPathEffect.cpp

diff --git a/src/effects/SkDashPathEffect.cpp b/src/effects/SkDashPathEffect.cpp

index ced0aab69a9930efbbd216127f776dd5d8c2770d..4e379e057b1243bd0db39b19ea061bd6eb71981d 100644

--- a/src/effects/SkDashPathEffect.cpp

+++ b/src/effects/SkDashPathEffect.cpp

@@ -14,7 +14,7 @@

SkDashPathEffect::SkDashPathEffect(const SkScalar intervals[], int count, SkScalar phase)

: fPhase(0)

robertphillips 2016/03/16 18:01:39 Don't we use a -1 initial dash length as a signal

caryclark 2016/03/16 18:45:54 Switched to explict flag. Please let me know if yo

- , fInitialDashLength(0)

+ , fInitialDashLength(-1)

, fInitialDashIndex(0)

, fIntervalLength(0) {

SkASSERT(intervals);

« no previous file with comments | « gm/arcto.cpp ('k') | src/utils/SkDashPath.cpp » ('j') | no next file with comments »