third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCRoot.cpp ('K') | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h ('k') | third_party/WebKit/Source/modules/speech/SpeechRecognition.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

index b28a3c21a69daaba273ea701abb07e049103d585..4ae96ad9f4638bb88957437d2d857ba9e5f52b89 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h

@@ -6,6 +6,7 @@

#define ServiceWorkerRegistration_h

#include "bindings/core/v8/ScriptPromiseResolver.h"

+#include "bindings/core/v8/V8GCRoot.h"

#include "core/dom/ActiveDOMObject.h"

#include "core/events/EventTarget.h"

#include "modules/serviceworkers/ServiceWorker.h"

@@ -31,7 +32,8 @@ class ServiceWorkerRegistration final

: public RefCountedGarbageCollectedEventTargetWithInlineData<ServiceWorkerRegistration>

, public ActiveDOMObject

, public WebServiceWorkerRegistrationProxy

- , public HeapSupplementable<ServiceWorkerRegistration> {

+ , public HeapSupplementable<ServiceWorkerRegistration>

+ , public V8GCRoot {

DEFINE_WRAPPERTYPEINFO();

REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(ServiceWorkerRegistration);

USING_GARBAGE_COLLECTED_MIXIN(ServiceWorkerRegistration);