third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8GCRoot.cpp ('K') | « third_party/WebKit/Source/modules/presentation/PresentationAvailability.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

index ee1325fddca1f91f9d248ddf9de501de814df3f4..cf7df9e709c5e05abfb96474ca78d49ecb6c3dd2 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h

@@ -33,6 +33,7 @@

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/SerializedScriptValue.h"

+#include "bindings/core/v8/V8GCRoot.h"

#include "core/workers/AbstractWorker.h"

#include "modules/ModulesExport.h"

#include "public/platform/modules/serviceworker/WebServiceWorker.h"

@@ -45,7 +46,7 @@ namespace blink {

class ScriptPromiseResolver;

-class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public WebServiceWorkerProxy {

+class MODULES_EXPORT ServiceWorker final : public AbstractWorker, public WebServiceWorkerProxy, public V8GCRoot {

DEFINE_WRAPPERTYPEINFO();

public:

static ServiceWorker* from(ExecutionContext*, PassOwnPtr<WebServiceWorker::Handle>);