Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
index ce1e3167b1125091996008d148c70878bdf1bd25..f4b2c8688f9edcf8a7af95b5a99c855101684dac 100644
--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
@@ -5,6 +5,7 @@
#ifndef MediaRecorder_h
#define MediaRecorder_h
+#include "bindings/core/v8/ActiveScriptWrappable.h"
#include "core/dom/ActiveDOMObject.h"
#include "core/events/EventTarget.h"
#include "modules/EventTargetModules.h"
@@ -24,6 +25,7 @@ class ExceptionState;
class MODULES_EXPORT MediaRecorder final
: public RefCountedGarbageCollectedEventTargetWithInlineData<MediaRecorder>
, public WebMediaRecorderHandlerClient
+ , public ActiveScriptWrappable
, public ActiveDOMObject {
REFCOUNTED_GARBAGE_COLLECTED_EVENT_TARGET(MediaRecorder);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MediaRecorder);
@@ -72,7 +74,9 @@ public:
void suspend() override;
void resume() override;
void stop() override;
- bool hasPendingActivity() const override { return !m_stopped; }
+
+ // ActiveScriptWrappable
+ bool hasPendingActivity() const final { return !m_stopped; }
// WebMediaRecorderHandlerClient
void writeData(const char* data, size_t length, bool lastInSlice) override;

Powered by Google App Engine
This is Rietveld 408576698