third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp - Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

Issue 1805843002: [v8 gc] Introduce a base class for all objects that can have pending activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h ('k') | third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

diff --git a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

index c35c3a4d664d80657d40a823f5ae514124422048..0f70afe9f24a469ad119e4d8b9ac47546c0f2b27 100644

--- a/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

+++ b/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp

@@ -132,7 +132,8 @@ MediaRecorder* MediaRecorder::create(ExecutionContext* context, MediaStream* str

}

MediaRecorder::MediaRecorder(ExecutionContext* context, MediaStream* stream, const MediaRecorderOptions& options, ExceptionState& exceptionState)

- : ActiveDOMObject(context)

+ : ActiveScriptWrappable(this)

+ , ActiveDOMObject(context)

, m_stream(stream)

, m_streamAmountOfTracks(stream->getTracks().size())

, m_mimeType(options.mimeType())