Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 1805763002: [DevTools] Do not linkify relative urls. (Closed)

Created:
4 years, 9 months ago by dgozman
Modified:
4 years, 9 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not linkify relative urls. They happen to point to some DevTools frontend file, which is misleading at best. BUG=591123 Committed: https://crrev.com/f82e78397ae82e65234d5449297aa3a6661055c4 Cr-Commit-Position: refs/heads/master@{#382087}

Patch Set 1 #

Total comments: 2

Patch Set 2 : only scheme #

Patch Set 3 : only scheme #

Total comments: 2

Patch Set 4 : removed // #

Total comments: 4

Patch Set 5 : fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 2 3 4 1 chunk +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/platform/utilities.js View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
dgozman
Take a look please.
4 years, 9 months ago (2016-03-16 00:21:59 UTC) #2
caseq
I think in the particular scenario of the referred bug we could actually resolve the ...
4 years, 9 months ago (2016-03-16 00:50:33 UTC) #3
dgozman
PTAL
4 years, 9 months ago (2016-03-16 01:41:45 UTC) #4
caseq
https://codereview.chromium.org/1805763002/diff/40001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js File third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js (right): https://codereview.chromium.org/1805763002/diff/40001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js#newcode311 third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js:311: return !(/^([A-Za-z][A-Za-z0-9+.-]*):\/\//.test(url)); so javascript:alert('hello-world') is relative according to this? ...
4 years, 9 months ago (2016-03-16 01:44:28 UTC) #5
dgozman
https://codereview.chromium.org/1805763002/diff/40001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js File third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js (right): https://codereview.chromium.org/1805763002/diff/40001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js#newcode311 third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js:311: return !(/^([A-Za-z][A-Za-z0-9+.-]*):\/\//.test(url)); On 2016/03/16 01:44:28, caseq wrote: > so ...
4 years, 9 months ago (2016-03-16 01:55:18 UTC) #6
dgozman
PTAL
4 years, 9 months ago (2016-03-17 00:21:33 UTC) #7
caseq
lgtm https://codereview.chromium.org/1805763002/diff/60001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js File third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js (right): https://codereview.chromium.org/1805763002/diff/60001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js#newcode311 third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js:311: return !(/^([A-Za-z][A-Za-z0-9+.-]*):/.test(url)); nit: drop parenthesis before ':' https://codereview.chromium.org/1805763002/diff/60001/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js ...
4 years, 9 months ago (2016-03-17 00:28:39 UTC) #8
dgozman
https://codereview.chromium.org/1805763002/diff/60001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js File third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js (right): https://codereview.chromium.org/1805763002/diff/60001/third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js#newcode311 third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js:311: return !(/^([A-Za-z][A-Za-z0-9+.-]*):/.test(url)); On 2016/03/17 00:28:39, caseq wrote: > nit: ...
4 years, 9 months ago (2016-03-18 19:06:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805763002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805763002/80001
4 years, 9 months ago (2016-03-18 19:07:21 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-18 21:17:22 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 21:19:23 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f82e78397ae82e65234d5449297aa3a6661055c4
Cr-Commit-Position: refs/heads/master@{#382087}

Powered by Google App Engine
This is Rietveld 408576698