third_party/WebKit/Source/devtools/front_end/components/Linkifier.js - Issue 1805763002: [DevTools] Do not linkify relative urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 1805763002: [DevTools] Do not linkify relative urls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/common/ParsedURL.js ('k') | third_party/WebKit/Source/devtools/front_end/platform/utilities.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

index 439eefdb3027728d4f6672b172ba6263033e54c6..6e70d88d6ddf833e282990a13c644517cae0f4e9 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

@@ -512,14 +512,17 @@ WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, too

{

if (!linkText)

linkText = url;

- classes = (classes ? classes + " " : "");

- classes += isExternal ? "webkit-html-external-link" : "webkit-html-resource-link";

- var a = createElement("a");

- var href = sanitizeHref(url);

- if (href !== null)

+ var a = createElementWithClass("a", classes);

+ var href = url;

+ if (url.trim().toLowerCase().startsWith("javascript:"))

+ href = null;

+ if (isExternal && WebInspector.ParsedURL.isRelativeURL(url))

+ href = null;

+ if (href !== null) {

a.href = href;

- a.className = classes;

+ a.classList.add(isExternal ? "webkit-html-external-link" : "webkit-html-resource-link");

+ }

if (!tooltipText && linkText !== url)

a.title = url;

else if (tooltipText)