Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1805733002: Disable logging on chromeos. (Closed)

Created:
4 years, 9 months ago by achuithb
Modified:
4 years, 9 months ago
Reviewers:
nednguyen, xdai1
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M telemetry/telemetry/testing/run_tests.py View 1 chunk +1 line, -6 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805733002/1
4 years, 9 months ago (2016-03-15 23:26:26 UTC) #2
achuithb
Ned, please take a look.
4 years, 9 months ago (2016-03-15 23:27:18 UTC) #4
achuithb
https://codereview.chromium.org/1805733002/diff/1/telemetry/telemetry/testing/run_tests.py File telemetry/telemetry/testing/run_tests.py (right): https://codereview.chromium.org/1805733002/diff/1/telemetry/telemetry/testing/run_tests.py#newcode234 telemetry/telemetry/testing/run_tests.py:234: logging.getLogger().handlers = [] Note these repeated lines, I believe ...
4 years, 9 months ago (2016-03-15 23:28:43 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-15 23:40:39 UTC) #7
nednguyen
lgtm
4 years, 9 months ago (2016-03-16 00:35:43 UTC) #8
xdai1
lgtm
4 years, 9 months ago (2016-03-16 00:36:24 UTC) #9
achuithb
On 2016/03/16 00:35:43, nednguyen wrote: > lgtm ty
4 years, 9 months ago (2016-03-16 00:37:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805733002/1
4 years, 9 months ago (2016-03-16 00:38:01 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 00:39:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698