Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1379063003: [Telemetry] Move listing stray processes to more appropriate places (Closed)

Created:
5 years, 2 months ago by nednguyen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Move listing stray processes to more appropriate places. We move telemetry's stray processes listing registration to telemetry's running entry points, i.e: benchmark_runner & run_tests instead of telemetry/__init__.py to avoid pylint script picking up this registration hook. BUG=536862 Committed: https://crrev.com/77694fdaad974a760189b3e345fcd5486b15b022 Cr-Commit-Position: refs/heads/master@{#352757}

Patch Set 1 #

Patch Set 2 : Apply kbr@'s fix from https://codereview.chromium.org/1378423004/ #

Total comments: 6

Patch Set 3 : EnablelListingStrayProcessesUponExitHook -> EnableListing.. #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -40 lines) Patch
M tools/telemetry/telemetry/benchmark_runner.py View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/global_hooks.py View 1 2 3 chunks +0 lines, -40 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/ps_util.py View 1 2 2 chunks +40 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/testing/run_tests.py View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
nednguyen
5 years, 2 months ago (2015-10-06 03:38:42 UTC) #2
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/1379063003/diff/20001/tools/telemetry/telemetry/benchmark_runner.py File tools/telemetry/telemetry/benchmark_runner.py (right): https://codereview.chromium.org/1379063003/diff/20001/tools/telemetry/telemetry/benchmark_runner.py#newcode391 tools/telemetry/telemetry/benchmark_runner.py:391: ps_util.EnablelListingStrayProcessesUponExitHook() Typo. Enablel -> Enable https://codereview.chromium.org/1379063003/diff/20001/tools/telemetry/telemetry/internal/util/ps_util.py File tools/telemetry/telemetry/internal/util/ps_util.py ...
5 years, 2 months ago (2015-10-06 23:51:11 UTC) #3
nednguyen
https://codereview.chromium.org/1379063003/diff/20001/tools/telemetry/telemetry/benchmark_runner.py File tools/telemetry/telemetry/benchmark_runner.py (right): https://codereview.chromium.org/1379063003/diff/20001/tools/telemetry/telemetry/benchmark_runner.py#newcode391 tools/telemetry/telemetry/benchmark_runner.py:391: ps_util.EnablelListingStrayProcessesUponExitHook() On 2015/10/06 23:51:10, Ken Russell wrote: > Typo. ...
5 years, 2 months ago (2015-10-07 00:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379063003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379063003/40001
5 years, 2 months ago (2015-10-07 00:25:42 UTC) #7
commit-bot: I haz the power
Failed to apply patch for tools/telemetry/telemetry/testing/run_tests.py: While running git apply --index -3 -p1; error: patch ...
5 years, 2 months ago (2015-10-07 02:06:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379063003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379063003/60001
5 years, 2 months ago (2015-10-07 02:14:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/63625) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 2 months ago (2015-10-07 02:37:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379063003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379063003/60001
5 years, 2 months ago (2015-10-07 02:40:04 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-07 03:39:56 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 03:40:42 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/77694fdaad974a760189b3e345fcd5486b15b022
Cr-Commit-Position: refs/heads/master@{#352757}

Powered by Google App Engine
This is Rietveld 408576698