Fix missing comma in HeadersToIgnore array.

Fix missing comma in HeadersToIgnore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955
Committed: https://crrev.com/f6a13f365cebaa2e53f32a07dcc79b52134a9d60
Cr-Commit-Position: refs/heads/master@{#384507}

[etienneb, 2016-03-15 22:54:07]

Description was changed from

==========
Fix missing comma in HeadersToIngore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955
==========

to

==========
Fix missing comma in HeadersToIgnore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955
==========

[etienneb, 2016-03-15 22:55:05]

The CQ bit was checked by etienneb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-15 22:55:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/1

[etienneb, 2016-03-15 22:56:45]

PTAL.

[commit-bot: I haz the power, 2016-03-16 01:18:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-16 01:18:29]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-03-16 12:05:59]

Ah! That's a terrible bug, good catch.

LGTM, but please add a test to make sure we don't regress this.

[etienneb, 2016-03-23 20:56:38]

Mike West, could you look back over my shoulders.
I have no idea what I'm doing in these files.

I added an unittest. It's catching the mistake.
I want to be sure I'm using correctly these classes and their API.

It's not a piece of code I'm familiar with.

Please, re-lgtm.

[etienneb, 2016-03-29 15:08:14]

The CQ bit was checked by etienneb@chromium.org

[etienneb, 2016-03-29 15:08:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1805713002/#ps20001
(title: "adding unittest")

[commit-bot: I haz the power, 2016-03-29 15:08:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/20001

[commit-bot: I haz the power, 2016-03-29 15:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 15:21:42]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[etienneb, 2016-03-29 18:21:56]

The CQ bit was checked by etienneb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-29 18:22:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/20001

[commit-bot: I haz the power, 2016-03-29 18:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 18:33:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[etienneb, 2016-03-29 20:25:26]

The CQ bit was checked by etienneb@chromium.org

[commit-bot: I haz the power, 2016-03-29 20:26:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/20001

[commit-bot: I haz the power, 2016-03-29 20:37:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 20:37:32]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[etienneb, 2016-03-29 22:24:26]

The CQ bit was checked by etienneb@chromium.org

[commit-bot: I haz the power, 2016-03-29 22:25:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/20001

[commit-bot: I haz the power, 2016-03-29 22:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 22:38:03]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[grt (UTC plus 2), 2016-03-31 15:14:24]

grt@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2016-03-31 15:14:25]

Your checkout is out of date; see below.

https://codereview.chromium.org/1805713002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/RawResourceTest.cpp (right):

https://codereview.chromium.org/1805713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/RawResourceTest.cpp:179:
ResourcePtr<Resource> resource = new
RawResource(ResourceRequest("data:text/html,"), Resource::Raw);
new RawResource -> RawResource::create
ResourcePtr -> RefPtrWillBeRawPtr
(http://crrev.com/486e9870)

https://codereview.chromium.org/1805713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/RawResourceTest.cpp:235:
EXPECT_FALSE(resource->hasClients());
hasClients -> hasClientsOrObservers
(http://crrev.com/a4581858)

[etienneb, 2016-03-31 20:49:42]

thanks grt@

https://codereview.chromium.org/1805713002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/fetch/RawResourceTest.cpp (right):

https://codereview.chromium.org/1805713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/RawResourceTest.cpp:179:
ResourcePtr<Resource> resource = new
RawResource(ResourceRequest("data:text/html,"), Resource::Raw);
On 2016/03/31 15:14:25, grt (very slow) wrote:
> new RawResource -> RawResource::create
> ResourcePtr -> RefPtrWillBeRawPtr
> (http://crrev.com/486e9870)

Done.

https://codereview.chromium.org/1805713002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/fetch/RawResourceTest.cpp:235:
EXPECT_FALSE(resource->hasClients());
On 2016/03/31 15:14:25, grt (very slow) wrote:
> hasClients -> hasClientsOrObservers
> (http://crrev.com/a4581858)

Done.

[etienneb, 2016-03-31 21:10:43]

The CQ bit was checked by etienneb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 21:11:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/40001

[commit-bot: I haz the power, 2016-03-31 21:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 21:20:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[etienneb, 2016-03-31 21:56:54]

The CQ bit was checked by etienneb@chromium.org

[etienneb, 2016-03-31 21:56:55]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1805713002/#ps40001
(title: "rebased")

[commit-bot: I haz the power, 2016-03-31 21:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/40001

[commit-bot: I haz the power, 2016-03-31 23:36:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 23:36:02]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[etienneb, 2016-04-01 00:11:50]

The CQ bit was checked by etienneb@chromium.org

[commit-bot: I haz the power, 2016-04-01 00:12:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/40001

[commit-bot: I haz the power, 2016-04-01 06:13:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:13:54]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[etienneb, 2016-04-01 06:20:35]

The CQ bit was checked by etienneb@chromium.org

[commit-bot: I haz the power, 2016-04-01 06:21:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805713002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805713002/40001

[commit-bot: I haz the power, 2016-04-01 07:10:36]

Description was changed from

==========
Fix missing comma in HeadersToIgnore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955
==========

to

==========
Fix missing comma in HeadersToIgnore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955
==========

[commit-bot: I haz the power, 2016-04-01 07:10:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-01 07:11:48]

Description was changed from

==========
Fix missing comma in HeadersToIgnore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955
==========

to

==========
Fix missing comma in HeadersToIgnore array.

R=mkwst@chromium.org, morrita@chromium.org

BUG=589955

Committed: https://crrev.com/f6a13f365cebaa2e53f32a07dcc79b52134a9d60
Cr-Commit-Position: refs/heads/master@{#384507}
==========

[commit-bot: I haz the power, 2016-04-01 07:11:50]

Patchset 3 (id:??) landed as
https://crrev.com/f6a13f365cebaa2e53f32a07dcc79b52134a9d60
Cr-Commit-Position: refs/heads/master@{#384507}