Fix missing comma in HeadersToIgnore array.

third_party/WebKit/Source/core/fetch/RawResourceTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 156 matching lines @@
     EXPECT_EQ(nullptr, resource->resourceBuffer());
     EXPECT_EQ(memoryCache()->resourceForURL(KURL(ParsedURLString, "data:text/html,")), resource.get());
     memoryCache()->remove(resource.get());
 
     resource->removeClient(client.get());
     EXPECT_FALSE(resource->hasClients());
     EXPECT_FALSE(client->called());
     EXPECT_EQ(0u, client->data().size());
 }
 
+TEST(RawResourceTest, RevalidationSucceededUpdateHeaders)
+{
+    ResourcePtr<Resource> resource = new RawResource(ResourceRequest("data:text/html,"), Resource::Raw);

[grt (UTC plus 2), 2016/03/31 15:14:25]

new RawResource -> RawResource::create
ResourcePtr -> RefPtrWillBeRawPtr
(http://crrev.com/486e9870)

[etienneb, 2016/03/31 20:49:42]

Done.

+    ResourceResponse response;
+    response.setHTTPStatusCode(200);
+    response.addHTTPHeaderField("keep-alive", "keep-alive value");
+    response.addHTTPHeaderField("expires", "expires value");
+    response.addHTTPHeaderField("last-modified", "last-modified value");
+    response.addHTTPHeaderField("proxy-authenticate", "proxy-authenticate value");
+    response.addHTTPHeaderField("proxy-connection", "proxy-connection value");
+    response.addHTTPHeaderField("x-custom", "custom value");
+    resource->responseReceived(response, nullptr);
+    resource->finish();
+    memoryCache()->add(resource.get());
+
+    // Simulate a successful revalidation.
+    resource->setRevalidatingRequest(ResourceRequest("data:text/html,"));
+
+    // Validate that these headers pre-update.
+    EXPECT_EQ("keep-alive value", resource->response().httpHeaderField("keep-alive"));
+    EXPECT_EQ("expires value", resource->response().httpHeaderField("expires"));
+    EXPECT_EQ("last-modified value", resource->response().httpHeaderField("last-modified"));
+    EXPECT_EQ("proxy-authenticate value", resource->response().httpHeaderField("proxy-authenticate"));
+    EXPECT_EQ("proxy-authenticate value", resource->response().httpHeaderField("proxy-authenticate"));
+    EXPECT_EQ("proxy-connection value", resource->response().httpHeaderField("proxy-connection"));
+    EXPECT_EQ("custom value", resource->response().httpHeaderField("x-custom"));
+
+    OwnPtr<DummyClient> client = adoptPtr(new DummyClient);
+    resource->addClient(client.get());
+
+    // Perform a revalidation step.
+    ResourceResponse revalidatingResponse;
+    revalidatingResponse.setHTTPStatusCode(304);
+    // Headers that aren't copied with an 304 code.
+    revalidatingResponse.addHTTPHeaderField("keep-alive", "garbage");
+    revalidatingResponse.addHTTPHeaderField("expires", "garbage");
+    revalidatingResponse.addHTTPHeaderField("last-modified", "garbage");
+    revalidatingResponse.addHTTPHeaderField("proxy-authenticate", "garbage");
+    revalidatingResponse.addHTTPHeaderField("proxy-connection", "garbage");
+    // Header that is updated with 304 code.
+    revalidatingResponse.addHTTPHeaderField("x-custom", "updated");
+    resource->responseReceived(revalidatingResponse, nullptr);
+
+    // Validate the original response.
+    EXPECT_EQ(200, resource->response().httpStatusCode());
+
+    // Validate that these headers are not updated.
+    EXPECT_EQ("keep-alive value", resource->response().httpHeaderField("keep-alive"));
+    EXPECT_EQ("expires value", resource->response().httpHeaderField("expires"));
+    EXPECT_EQ("last-modified value", resource->response().httpHeaderField("last-modified"));
+    EXPECT_EQ("proxy-authenticate value", resource->response().httpHeaderField("proxy-authenticate"));
+    EXPECT_EQ("proxy-authenticate value", resource->response().httpHeaderField("proxy-authenticate"));
+    EXPECT_EQ("proxy-connection value", resource->response().httpHeaderField("proxy-connection"));
+    EXPECT_EQ("updated", resource->response().httpHeaderField("x-custom"));
+
+    memoryCache()->remove(resource.get());
+
+    resource->removeClient(client.get());
+    EXPECT_FALSE(resource->hasClients());

[grt (UTC plus 2), 2016/03/31 15:14:25]

hasClients -> hasClientsOrObservers
(http://crrev.com/a4581858)

[etienneb, 2016/03/31 20:49:42]

Done.

+    EXPECT_FALSE(client->called());
+    EXPECT_EQ(0u, client->data().size());
+}
+
 TEST(RawResourceTest, AddClientDuringCallback)
 {
     ResourcePtr<Resource> raw = new RawResource(ResourceRequest("data:text/html,"), Resource::Raw);
     raw->setLoading(false);
 
     // Create a non-null response.
     ResourceResponse response = raw->response();
     response.setURL(KURL(ParsedURLString, "http://600.613/"));
     raw->setResponse(response);
     EXPECT_FALSE(raw->response().isNull());
@@ skipping 39 matching lines @@
 
     OwnPtr<DummyClient> dummyClient = adoptPtr(new DummyClient());
     OwnPtr<RemovingClient> removingClient = adoptPtr(new RemovingClient(dummyClient.get()));
     raw->addClient(dummyClient.get());
     raw->addClient(removingClient.get());
     testing::runPendingTasks();
     EXPECT_FALSE(raw->hasClients());
 }
 
 } // namespace blink