Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1805673004: Include U+FE50-FE6F in isCJKIdeographOrSymbol() (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
drott
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include U+FE50-FE6F in isCJKIdeographOrSymbol() This patch includes U+FE50-FE6F Small Form Variants[1] in isCJKIdeographOrSymbol(). These code points are compatibility variants for the CNS (Chinese National Standards) 11643 character set. [1] http://www.unicode.org/charts/PDF/UFE50.pdf BUG=587325 Committed: https://crrev.com/718cda743f26d3c34f5869b419d7c71c9925a4f2 Cr-Commit-Position: refs/heads/master@{#381676}

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/fonts/CharacterPropertyData.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kojii
PTAL.
4 years, 9 months ago (2016-03-17 03:54:38 UTC) #4
drott
LGTM.
4 years, 9 months ago (2016-03-17 05:34:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805673004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805673004/20001
4 years, 9 months ago (2016-03-17 09:49:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 09:54:31 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 09:55:57 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/718cda743f26d3c34f5869b419d7c71c9925a4f2
Cr-Commit-Position: refs/heads/master@{#381676}

Powered by Google App Engine
This is Rietveld 408576698