third_party/WebKit/Source/platform/fonts/CharacterTest.cpp - Issue 1805673004: Include U+FE50-FE6F in isCJKIdeographOrSymbol()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

Issue 1805673004: Include U+FE50-FE6F in isCJKIdeographOrSymbol() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp b/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

index eaed51cccbb75244c6c139d0872aca94d201983a..4f0b86256dd6616e6e682f2484ea3b201e1beb16 100644

--- a/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

@@ -322,7 +322,7 @@ TEST(CharacterTest, TestIsCJKIdeographOrSymbol)

EXPECT_TRUE(Character::isCJKIdeographOrSymbol(0x33FF));

TestSpecificUChar32RangeIdeographSymbol(0xF860, 0xF862);

- TestSpecificUChar32RangeIdeographSymbol(0xFE30, 0xFE4F);

+ TestSpecificUChar32RangeIdeographSymbol(0xFE30, 0xFE6F);

EXPECT_TRUE(Character::isCJKIdeographOrSymbol(0xFE10));

EXPECT_TRUE(Character::isCJKIdeographOrSymbol(0xFE11));