Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1805673003: Re-enable IOSurface Canvas2D. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, f(malita), ajuma+watch-canvas_chromium.org, dshwang, jam, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, darin-cc_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp94_texture_size
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable IOSurface Canvas2D. The bug that caused retina IOSurface Canvas2D to fail in the non-CoreAnimation compositing path has been fixed. This CL also adds a pixel test. BUG=595063, 579664

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase. #

Patch Set 3 : Comments from kbr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -93 lines) Patch
A + content/test/data/gpu/pixel_canvas2d_webgl.html View 3 chunks +16 lines, -2 lines 0 comments Download
M content/test/data/gpu/pixel_webgl.html View 2 chunks +2 lines, -88 lines 0 comments Download
A content/test/data/gpu/pixel_webgl_util.js View 1 chunk +95 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
erikchen
kbr: Please review.
4 years, 9 months ago (2016-03-15 23:23:59 UTC) #3
Ken Russell (switch to Gerrit)
Awesome work! LGTM. https://codereview.chromium.org/1805673003/diff/1/content/test/gpu/page_sets/pixel_tests.py File content/test/gpu/page_sets/pixel_tests.py (right): https://codereview.chromium.org/1805673003/diff/1/content/test/gpu/page_sets/pixel_tests.py#newcode75 content/test/gpu/page_sets/pixel_tests.py:75: url='file://../../data/gpu/pixel_canvas2d_webgl.html', This is excellent. Could you ...
4 years, 9 months ago (2016-03-16 00:45:55 UTC) #4
erikchen
https://codereview.chromium.org/1805673003/diff/1/content/test/gpu/page_sets/pixel_tests.py File content/test/gpu/page_sets/pixel_tests.py (right): https://codereview.chromium.org/1805673003/diff/1/content/test/gpu/page_sets/pixel_tests.py#newcode75 content/test/gpu/page_sets/pixel_tests.py:75: url='file://../../data/gpu/pixel_canvas2d_webgl.html', On 2016/03/16 00:45:55, Ken Russell wrote: > This ...
4 years, 9 months ago (2016-03-16 01:07:10 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805673003/40001
4 years, 9 months ago (2016-03-16 01:07:38 UTC) #7
Ken Russell (switch to Gerrit)
Excellent. Still LGTM.
4 years, 9 months ago (2016-03-16 01:37:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 05:20:42 UTC) #10
erikchen
4 years, 9 months ago (2016-03-16 18:02:26 UTC) #11 
On 2016/03/16 05:20:42, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

This CL has been patched into https://codereview.chromium.org/1804243002/#msg20,
as requested by kbr@.

Powered by Google App Engine
This is Rietveld 408576698