Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1805653002: Add regression test for crbug.com/594072 (Closed)

Created:
4 years, 9 months ago by Nate Chapin
Modified:
4 years, 9 months ago
Reviewers:
hiroshige, dcheng
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add regression test for crbug.com/594072 BUG=594072 Committed: https://crrev.com/d550d827c044a0d4185fafe9fe03eed4ea77c1da Cr-Commit-Position: refs/heads/master@{#381500}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp View 1 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nate Chapin
Here's the test for https://codereview.chromium.org/1802693002/. It turned out to be easier than I thought. Schedule ...
4 years, 9 months ago (2016-03-15 20:25:05 UTC) #2
dcheng
lgtm
4 years, 9 months ago (2016-03-15 21:49:58 UTC) #3
hiroshige
Can we add more tests to call serveAsynchronousMockedRequests() inside other override methods of RawResourceClient (i.e. ...
4 years, 9 months ago (2016-03-15 21:52:34 UTC) #4
Nate Chapin
https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp File third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp (right): https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp#newcode247 third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:247: On 2016/03/15 21:52:34, hiroshige wrote: > In addition to ...
4 years, 9 months ago (2016-03-16 17:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805653002/20001
4 years, 9 months ago (2016-03-16 17:05:00 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 18:18:13 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 18:20:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d550d827c044a0d4185fafe9fe03eed4ea77c1da
Cr-Commit-Position: refs/heads/master@{#381500}

Powered by Google App Engine
This is Rietveld 408576698