Add regression test for crbug.com/594072

Add regression test for crbug.com/594072

BUG=594072
Committed: https://crrev.com/d550d827c044a0d4185fafe9fe03eed4ea77c1da
Cr-Commit-Position: refs/heads/master@{#381500}

[Nate Chapin, 2016-03-15 20:25:04]

japhet@chromium.org changed reviewers:
+ dcheng@chromium.org, hiroshige@chromium.org

[Nate Chapin, 2016-03-15 20:25:05]

Here's the test for https://codereview.chromium.org/1802693002/.

It turned out to be easier than I thought. Schedule a properly mocked load,
cancel it, and have a ResourceClient call ServeRequestsOnCompleteClient inside
notifyFinished() will get the RELEASE_ASSERT with
https://codereview.chromium.org/1802693002/ reverted.

[dcheng, 2016-03-15 21:49:58]

lgtm

[hiroshige, 2016-03-15 21:52:34]

Can we add more tests to call serveAsynchronousMockedRequests() inside other
override methods of RawResourceClient (i.e. other places where javascript might
be called)?
It's better to test similar things do not occur.

https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp (right):

https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:247: 
In addition to the RELEASE_ASSERT, how about adding mock methods for other
RawResourceClient here and checks they are not called inside cancel()? Doing so
would make the test more robust for future change.

https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:251:
TEST_F(ResourceFetcherTest, ResponseOnCancel)
How about adding comments that have
- link to Issue 594072 to provide the context for this test
- description of the expected behavior, i.e. the test not to be crashed.

[Nate Chapin, 2016-03-16 17:04:03]

https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp (right):

https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:247: 
On 2016/03/15 21:52:34, hiroshige wrote:
> In addition to the RELEASE_ASSERT, how about adding mock methods for other
> RawResourceClient here and checks they are not called inside cancel()? Doing
so
> would make the test more robust for future change.

Done.

https://codereview.chromium.org/1805653002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:251:
TEST_F(ResourceFetcherTest, ResponseOnCancel)
On 2016/03/15 21:52:34, hiroshige wrote:
> How about adding comments that have
> - link to Issue 594072 to provide the context for this test
> - description of the expected behavior, i.e. the test not to be crashed.

Done.

[Nate Chapin, 2016-03-16 17:04:39]

The CQ bit was checked by japhet@chromium.org

[Nate Chapin, 2016-03-16 17:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1805653002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-03-16 17:05:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805653002/20001

[commit-bot: I haz the power, 2016-03-16 18:18:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 18:20:51]

Description was changed from

==========
Add regression test for crbug.com/594072

BUG=594072
==========

to

==========
Add regression test for crbug.com/594072

BUG=594072

Committed: https://crrev.com/d550d827c044a0d4185fafe9fe03eed4ea77c1da
Cr-Commit-Position: refs/heads/master@{#381500}
==========

[commit-bot: I haz the power, 2016-03-16 18:20:51]

Patchset 2 (id:??) landed as
https://crrev.com/d550d827c044a0d4185fafe9fe03eed4ea77c1da
Cr-Commit-Position: refs/heads/master@{#381500}