Add regression test for crbug.com/594072

third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 16 matching lines @@
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "core/fetch/ResourceFetcher.h"
 
 #include "core/fetch/FetchInitiatorInfo.h"
 #include "core/fetch/FetchInitiatorTypeNames.h"
 #include "core/fetch/FetchRequest.h"
 #include "core/fetch/MemoryCache.h"
+#include "core/fetch/RawResource.h"
 #include "core/fetch/ResourceLoader.h"
 #include "platform/exported/WrappedResourceResponse.h"
 #include "platform/heap/Handle.h"
 #include "platform/network/ResourceRequest.h"
 #include "platform/testing/URLTestHelpers.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebURLResponse.h"
 #include "public/platform/WebUnitTestSupport.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 183 matching lines @@
     ResourceRequest request(KURL(ParsedURLString, "data:text/html,foo"));
     ResourceLoaderOptions options;
     options.dataBufferingPolicy = DoNotBufferData;
     FetchRequest fetchRequest = FetchRequest(request, FetchInitiatorTypeNames::internal, options);
     RefPtrWillBeRawPtr<Resource> resource1 = fetcher->requestResource(fetchRequest, TestResourceFactory(Resource::Media));
     RefPtrWillBeRawPtr<Resource> resource2 = fetcher->requestResource(fetchRequest, TestResourceFactory(Resource::Media));
     EXPECT_NE(resource1.get(), resource2.get());
     memoryCache()->remove(resource2.get());
 }
 
+class ServeRequestsOnCompleteClient : public RawResourceClient {
+public:
+    void notifyFinished(Resource*) override
+    {
+        Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
+    }
+

[hiroshige, 2016/03/15 21:52:34]

In addition to the RELEASE_ASSERT, how about adding mock methods for other
RawResourceClient here and checks they are not called inside cancel()? Doing so
would make the test more robust for future change.

[Nate Chapin, 2016/03/16 17:04:03]

Done.

+    String debugName() const override { return "ServeRequestsOnCompleteClient"; }
+};
+
+TEST_F(ResourceFetcherTest, ResponseOnCancel)

[hiroshige, 2016/03/15 21:52:34]

How about adding comments that have
- link to Issue 594072 to provide the context for this test
- description of the expected behavior, i.e. the test not to be crashed.

[Nate Chapin, 2016/03/16 17:04:03]

Done.

+{
+    KURL url(ParsedURLString, "http://127.0.0.1:8000/foo.html");
+    ResourceResponse response;
+    response.setURL(url);
+    response.setHTTPStatusCode(200);
+    URLTestHelpers::registerMockedURLLoadWithCustomResponse(url, "white-1x1.png", WebString::fromUTF8(""), WrappedResourceResponse(response));
+
+    ResourceFetcher* fetcher = ResourceFetcher::create(ResourceFetcherTestMockFetchContext::create());
+    FetchRequest fetchRequest = FetchRequest(url, FetchInitiatorInfo());
+    RefPtrWillBeRawPtr<Resource> resource = fetcher->requestResource(fetchRequest, TestResourceFactory(Resource::Raw));
+    ServeRequestsOnCompleteClient client;
+    resource->addClient(&client);
+    resource->loader()->cancel();
+    Platform::current()->unitTestSupport()->unregisterMockedURL(url);
+}
+
 } // namespace blink