Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h - Issue 180553004: Fix use-after-free of m_currentSpeechUtterance.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h

Issue 180553004: Fix use-after-free of m_currentSpeechUtterance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix nullptr again? Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h

diff --git a/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h b/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h

index 3e3e726727bd92d523330e6c52e215317fa2928f..aedc2d037dc07dc0a77eb621cca4a66eb0a42bf6 100644

--- a/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h

+++ b/Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h

@@ -46,8 +46,10 @@ private:

explicit PlatformSpeechSynthesizerMock(PlatformSpeechSynthesizerClient*);

virtual void initializeVoiceList() OVERRIDE;

void speakingFinished(Timer<PlatformSpeechSynthesizerMock>*);

+ void speakingErrorOccurred(Timer<PlatformSpeechSynthesizerMock>*);

Timer<PlatformSpeechSynthesizerMock> m_speakingFinishedTimer;

+ Timer<PlatformSpeechSynthesizerMock> m_speakingErrorOccurredTimer;

RefPtr<PlatformSpeechSynthesisUtterance> m_utterance;

};