Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h - Issue 180553004: Fix use-after-free of m_currentSpeechUtterance.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/speech/testing/PlatformSpeechSynthesizerMock.h

Issue 180553004: Fix use-after-free of m_currentSpeechUtterance. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix nullptr again? Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/speech/SpeechSynthesis.cpp ('k') | Source/modules/speech/testing/PlatformSpeechSynthesizerMock.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2013 Apple Computer, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 28 matching lines...) Expand all Loading...
39 virtual ~PlatformSpeechSynthesizerMock();	39 virtual ~PlatformSpeechSynthesizerMock();

40 virtual void speak(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;	40 virtual void speak(PassRefPtr<PlatformSpeechSynthesisUtterance>) OVERRIDE;

41 virtual void pause() OVERRIDE;	41 virtual void pause() OVERRIDE;

42 virtual void resume() OVERRIDE;	42 virtual void resume() OVERRIDE;

43 virtual void cancel() OVERRIDE;	43 virtual void cancel() OVERRIDE;

44	44

45 private:	45 private:

46 explicit PlatformSpeechSynthesizerMock(PlatformSpeechSynthesizerClient*);	46 explicit PlatformSpeechSynthesizerMock(PlatformSpeechSynthesizerClient*);

47 virtual void initializeVoiceList() OVERRIDE;	47 virtual void initializeVoiceList() OVERRIDE;

48 void speakingFinished(Timer<PlatformSpeechSynthesizerMock>*);	48 void speakingFinished(Timer<PlatformSpeechSynthesizerMock>*);

	49 void speakingErrorOccurred(Timer<PlatformSpeechSynthesizerMock>*);

49	50

50 Timer<PlatformSpeechSynthesizerMock> m_speakingFinishedTimer;	51 Timer<PlatformSpeechSynthesizerMock> m_speakingFinishedTimer;

	52 Timer<PlatformSpeechSynthesizerMock> m_speakingErrorOccurredTimer;

51 RefPtr<PlatformSpeechSynthesisUtterance> m_utterance;	53 RefPtr<PlatformSpeechSynthesisUtterance> m_utterance;

52 };	54 };

53	55

54 } // namespace WebCore	56 } // namespace WebCore

55	57

56 #endif // PlatformSpeechSynthesizer_h	58 #endif // PlatformSpeechSynthesizer_h

OLD	NEW